8000 Specific asserts by zware · Pull Request #205 · python/typing · GitHub
[go: up one dir, main page]
Skip to content

Specific asserts #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 19, 2016
Merged

Specific asserts #205

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f5d8974
Add base test case with assert*IsSubclass
zware Apr 18, 2016
8f35d4b
Use specific IsInstance asserts
zware Apr 18, 2016
b67d31f
Use self.assertEqual instead of assert ... == ...
zware Apr 18, 2016
5ee93c2
Use self.assertNotEqual instead of assert ... != ...
zware Apr 18, 2016
ed77972
Use self.assertIs instead of assert ... is ...
zware Apr 18, 2016
e012232
Use self.assertIn and self.assertNotIn
zware Apr 18, 2016
1bb7de6
Fix last remaining assert statement
zware Apr 18, 2016
b1aa749
Remove misleading comment, TestCase->BaseTestCase
zware Apr 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix last remaining assert statement
  • Loading branch information
@zware
zware committed Apr 18, 2016
commit 1bb7de671926252f46f7cddc470dca89d8727dfd
4 changes: 2 additions & 2 deletions src/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,8 +632,8 @@ class C(Generic[T]):
self.assertNotEqual(Z, Y[int])
self.assertNotEqual(Z, Y[T])

assert str(Z).endswith(
'.C<~T>[typing.Tuple[~S, ~T]]<~S, ~T>[~T, int]<~T>[str]')
self.assertTrue(str(Z).endswith(
'.C<~T>[typing.Tuple[~S, ~T]]<~S, ~T>[~T, int]<~T>[str]'))

def test_dict(self):
T = TypeVar('T')
Expand Down
0