8000 Add missing import in enums_members.py by PetrGolubev · Pull Request #1985 · python/typing · GitHub
[go: up one dir, main page]
Skip to content

Add missing import in enums_members.py #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Add missing import in enums_members.py #1985

merged 1 commit into from
Apr 24, 2025

Conversation

PetrGolubev
Copy link
Contributor

No description provided.

@python-cla-bot
Copy link
python-cla-bot bot commented Apr 24, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@JelleZijlstra
Copy link
Member

This isn't strictly needed, as type checkers can assume reveal_type() is always imported. However, we don't currently specify this (https://typing.python.org/en/latest/spec/directives.html#reveal-type).

@PetrGolubev
Copy link
Contributor Author

My guess was that it's more reliable to have an actual import here since the spec doesn't explicitly say that it's optional.
And a type checker may choose to report an error as it causes an exception in runtime. Other tests that use reveal_type also import it.

@erictraut erictraut merged commit 3149e8c into python:main Apr 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PetrGolubev @JelleZijlstra @erictraut
0