10000 stripe checkout session stub by denyszhak · Pull Request #9814 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

stripe checkout session stub #9814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 27, 2023
Merged

stripe checkout session stub #9814

merged 3 commits into from
Feb 27, 2023

Conversation

denyszhak
Copy link
Contributor
@denyszhak denyszhak commented Feb 25, 2023 •
edited by AlexWaygood
Loading

Closes #9693
Session was missing stubs

@github-actions

This comment has been minimized.

Sign in to view
@AlexWaygood
Copy link
Member

Thanks! A lot of the methods in stripe are pretty hard to type -- the decorator you can see here in the source code means that the expire() method can be called both as an instance method and as a classmethod at runtime. It's not really possible to express that in the stub without a few hacks, unfortunately, so I've pushed an update to your PR along the lines of how we've previously approached this problem in #8498.

@AlexWaygood AlexWaygood requested a review from srittau February 27, 2023 13:02
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 6b98f73 into python:main Feb 27, 2023
@AlexWaygood AlexWaygood mentioned this pull request Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing stripe.checkout.Session.expire stub
3 participants
@denyszhak @AlexWaygood @srittau
0