8000 stdlib: add defaults by JelleZijlstra · Pull Request #9501 · python/typeshed · GitHub
[go: up one dir, main page]

Skip to content

stdlib: add defaults #9501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jan 18, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
not sure why pyright is happy now
  • Loading branch information
JelleZijlstra committed Jan 18, 2023
commit 508dd86b6858c92696b90e00a6115f55849a357c
3 changes: 1 addition & 2 deletions stdlib/subprocess.pyi
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,11 @@ class CompletedProcess(Generic[_T]):
# and writing all the overloads would be horrific.
stdout: _T
stderr: _T
# pyright ignore on __init__ because the TypeVar can technically be unsolved, but see comment above
def __init__(
self,
args: _CMD,
returncode: int,
stdout: _T | None = None, # pyright: ignore[reportInvalidTypeVarUse]
stdout: _T | None = None,
stderr: _T | None = None,
) -> None: ...
def check_returncode(self) -> None: ...
Expand Down
0