8000 Port decimal stub to Python 2 by youtux · Pull Request #95 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Port decimal stub to Python 2 #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 26, 2016
Merged

Port decimal stub to Python 2 #95

merged 4 commits into from
Feb 26, 2016

Conversation

youtux
Copy link
Contributor
@youtux youtux commented Feb 26, 2016

Python 2/3 specific code has been commented and TODOs were added, according to #94 (comment).

@gvanrossum
Copy link
Member

I apologize for the advice I gave earlier. I think it's better to have separate decimal.pyi files for 2.7 and 3 after all. The number of sections with version-specific comments in this version scares me.

@youtux
Copy link
Contributor Author
youtux commented Feb 26, 2016

Yeah, the single-file strategy would make sense if mypy supported version-specific comments, but until that moment it's better to split.

gvanrossum added a commit that referenced this pull request Feb 26, 2016
@gvanrossum
Merge pull request #95 from youtux/feature/decimal-2.7
0a49691 
Port decimal stub to Python 2
@gvanrossum gvanrossum merged commit 0a49691 into python:master Feb 26, 2016
@youtux youtux deleted the feature/decimal-2.7 branch February 26, 2016 21:21
gvanrossum pushed a commit that referenced this pull request Mar 8, 2016
Revert "Merge pull request #95 from youtux/feature/decimal-2.7"
6a49621 
This broke our build.

This reverts commit 0a49691, reversing
changes made to c8630a2.
@gvanrossum
Copy link
Member

I'm really sorry, I had to roll this back because there were some deficiencies. For example:

  • __div__ and __rdiv__ were missing
  • comparison to float should be possible

@youtux youtux restored the feature/decimal-2.7 branch March 8, 2016 19:23
@youtux
Copy link
Contributor Author
youtux commented Mar 8, 2016

I'll try to fix it as soon as I can. Thank you for pointing that out.

hswong3i pushed a commit to alvistack/python-typeshed that referenced this pull request May 25, 2025
@carljm
Add Python 3.11 to tox.ini (python#95)
8042f3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youtux @gvanrossum
0