8000 Delete stubs for `cryptography` by AlexWaygood · Pull Request #9459 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Delete stubs for cryptography #9459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 10, 2023
Merged

Delete stubs for cryptography #9459

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bd2b21
Delete stubs for `cryptography`
AlexWaygood Jan 4, 2023
1a7626e
Make pyright happy
AlexWaygood Jan 4, 2023
fa48deb
Add some lower bounds
AlexWaygood Jan 5, 2023
a0d060f
Merge branch 'main' into delete-cryptography
AlexWaygood Jan 7, 2023
1ce3c36
Merge branch 'main' into delete-cryptography
AlexWaygood Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add some lower bounds
  • Loading branch information
@AlexWaygood
AlexWaygood committed Jan 5, 2023
commit fa48deb6f8d650523431a964c65ffc4bc476674f
3 changes: 2 additions & 1 deletion stubs/paramiko/METADATA.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
version = "2.12.*"
requires = ["cryptography"]
# Requires a version of cryptography where cryptography.hazmat.primitives.ciphers.Cipher is generic
requires = ["cryptography>=37.0.0"]

[tool.stubtest]
# linux and darwin are equivalent
Expand Down
3 changes: 2 additions & 1 deletion stubs/pyOpenSSL/METADATA.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
version = "23.0.*"
requires = ["cryptography"]
# Requires a version of cryptography with a `py.typed` file
requires = ["cryptography>=35.0.0"]
Copy link
Collaborator
@Avasam Avasam Jan 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I feel like it would make sense to always enforce a minimal version for external dependencies of 3rd party stub.

Copy link
Member Author
@AlexWaygood AlexWaygood Jan 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea — definitely something we should explore in the future!

Copy link
Collaborator
@Avasam Avasam Jan 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having to enforce it through CI. Maybe a mention in documentation that external dependencies should be at least pinned to their first py.typed version? And optimally to the oldest version that has the types referenced by the stub.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to work on docs as soon as this PR makes it over the line — this is a very good point, thanks!

0