8000 Complete stubtest for `aiofiles` + fix on Windows by Avasam · Pull Request #9184 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Complete stubtest for aiofiles + fix on Windows #9184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Complete stubtest for aiofiles + fix on Windows #9184

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c667d2
Complete stubtest for `aiofiles` + fix on Windows
Avasam Nov 12, 2022
03dead6
Incomplete close parameters
Avasam Nov 13, 2022
e7bd820
Merge branch 'main' of https://github.com/python/typeshed into stubte…
Avasam Nov 13, 2022
3fb2283
Update AsyncSpooledTemporaryFile.close
Avasam Nov 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Incomplete close parameters
  • Loading branch information
@Avasam
Avasam committed Nov 13, 2022
commit 03dead67fb1c9392872fb8e2f65a30069d65892a
2 changes: 1 addition & 1 deletion stubs/aiofiles/aiofiles/tempfile/temptypes.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ _T = TypeVar("_T")
class AsyncSpooledTemporaryFile(AsyncBase[_T]):
def fileno(self) -> Generator[Incomplete, Incomplete, Incomplete]: ...
def rollover(self) -> Generator[Incomplete, Incomplete, Incomplete]: ...
async def close(self) -> None: ...
async def close(self, *args: Incomplete, **kwargs: Incomplete) -> None: ...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async def close(self, *args: Incomplete, **kwargs: Incomplete) -> None: ...
async def close(self) -> None: ...

This gets delegated to the underlying file's close() method.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I wasn't sure of the exact signature. I'll add an allowlist entry.

async def flush(self) -> None: ...
async def isatty(self) -> bool: ...
# All must return `AnyStr`:
Expand Down
0