8000 Run stubtest on all third party stubs if requirements.txt is changed by sobolevn · Pull Request #9132 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Run stubtest on all third party stubs if requirements.txt is changed #9132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 9, 2022
Merged

Run stubtest on all third party stubs if requirements.txt is changed #9132

merged 5 commits into from
Nov 9, 2022

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Nov 8, 2022

Closes #9128

Let's test it, plan:

  1. Now daily must not run
  2. Next, I will add something to the requirements
  3. It must run 🎉
  4. I will add daily.yml itself to paths:, because when it is changed, we need to validate the correctness of the change

@sobolevn
Copy link
Member Author
sobolevn commented Nov 8, 2022

Ok, here we go: changing requirements.

@AlexWaygood
Copy link
Member

You should remove this line, or we'll get a double run of stdlib stubtest when we tinker with requirements-tests.txt:

typeshed/.github/workflows/stubtest_stdlib.yml

Line 13 in 4f381af

- 'requirements-tests.txt'

AlexWaygood
AlexWaygood reviewed Nov 9, 2022
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn
Copy link
Member Author
sobolevn commented Nov 9, 2022

Thanks for the review. Next I propose to merge #8923

I will fix merge conflicts in a moment.

@AlexWaygood AlexWaygood merged commit cb5ed3c into python:main Nov 9, 2022
@sobolevn sobolevn mentioned this pull request Nov 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run stubtest on all third party stubs if requirements.txt is changed
2 participants
@sobolevn @AlexWaygood
0