8000 unittest: cannot use bytes regexes by JelleZijlstra · Pull Request #9107 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

unittest: cannot use bytes regexes #9107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2022
Merged

unittest: cannot use bytes regexes #9107

merged 2 commits into from
Nov 5, 2022

Conversation

JelleZijlstra
Copy link
Member
@JelleZijlstra JelleZijlstra commented Nov 5, 2022 •
edited by AlexWaygood
Loading 
>>> from unittest.case import TestCase
>>> c = TestCase()
>>> with c.assertRaisesRegex(Exception, b"x"): 1/0
...
ZeroDivisionError: division by zero

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/unittest/case.py", line 274, in __exit__
    if not expected_regex.search(str(exc_value)):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: cannot use a bytes pattern on a string-like object

JelleZijlstra and others added 2 commits November 5, 2022 07:53
@JelleZijlstra
unittest: cannot use bytes regexes
118a922 
>>> from unittest.case import TestCase
>>> c = TestCase()
>>> with c.assertRaisesRegex(Exception, b"x"): 1/0
...
ZeroDivisionError: division by zero

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/unittest/case.py", line 274, in __exit__
    if not expected_regex.search(str(exc_value)):
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: cannot use a bytes pattern on a string-like object
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
43b43a4
@github-actions
Copy link
Contributor
github-actions bot commented Nov 5, 2022

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JelleZijlstra JelleZijlstra mentioned this pull request Nov 5, 2022
Open
@hauntsaninja hauntsaninja merged commit 1f76489 into python:main Nov 5, 2022
@AlexWaygood
Copy link
Member

sad, i always wanted to

@JelleZijlstra JelleZijlstra deleted the unittest branch November 5, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JelleZijlstra @AlexWaygood @hauntsaninja
0