asyncore: improve bytes handling #9034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really want to spend my time reviewing a PR like this for a module that's long-deprecated and about to be removed :( Same goes for #9035 |
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Yeah, I can totally understand, sometimes I feel this too! But, since typeshed still supports >=3.7, people are and will still use these modules. Maybe someone else will review it! If you feel like it, closing these two PRs is always an option. |
|
Yeah, to be clear — I've no objections to other maintainers reviewing and merging this if they want to :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source: https://github.com/python/cpython/blob/7ea10567afe38e7770e82b4642c0b01659acaad5/Lib/asyncore.py
asyncore.sendcallssocket.send: https://github.com/python/cpython/blob/7ea10567afe38e7770e82b4642c0b01659acaad5/Lib/asyncore.py#L363