_codecs: Fix buffer parameters #9003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
commented
Oct 27, 2022
| def charmap_encode(__str: str, __errors: str | None = ..., __mapping: _CharMap | None = ...) -> tuple[bytes, int]: ... | ||
| def escape_decode(__data: str | bytes, __errors: str | None = ...) -> tuple[str, int]: ... | ||
| def escape_decode(__data: str | ReadableBuffer, __errors: str | None = ...) -> tuple[str, int]: ... | ||
| def escape_encode(__data: bytes, __errors: str | None = ...) -> tuple[bytes, int]: ... |
There was a problem hiding this comment.
This one is really just bytes:
>>> _codecs.escape_encode(bytearray(b"x"))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: escape_encode() argument 1 must be bytes, not bytearray
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Oct 28, 2022
There was a problem hiding this comment.
I've only found this in the Python docs in regards to whether codecs should be able to handle any buffer:
https://docs.python.org/3/library/codecs.html?highlight=codec#codecs.Codec.decode
Codec.decode(input, errors='strict')
[...]
For text encodings and bytes-to-bytes codecs, input must be a bytes object or on 7BA6 e which provides the read-only buffer interface – for example, buffer objects and memory mapped files.
But I guess this kind of implies that generally buffer protocol objects are okay where bytes are allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.