8000 Remove invalid Python 3 syntax by ddfisher · Pull Request #85 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Remove invalid Python 3 syntax #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2016
Merged

Remove invalid Python 3 syntax #85

merged 2 commits into from
Feb 24, 2016

Conversation

ddfisher
Copy link
Contributor

Fix #83.

@matthiaskramm
Copy link
Contributor

Could you put a prominent comment into stdlib/2/builtins.pyi that True and False have been deliberately left out?

@ddfisher
Copy link
Contributor Author

That seems like a good idea -- added.

@matthiaskramm
Copy link
Contributor

Thanks! Let me know if you want me to merge the PR. I take it mypy needs to be adjusted, too.

@ddfisher
Copy link
Contributor Author

Yeah, mypy will need to be adjusted. I have a PR out for that here, that should be pretty much ready to merge after this change.

I guess the CI build will just have to fail in the meanwhile?

@ddfisher
Copy link
Contributor Author

If that seems reasonable, please merge. :)

matthiaskramm added a commit that referenced this pull request Feb 24, 2016
@matthiaskramm
Merge pull request #85 from ddfisher/master
335ef31 
Remove invalid Python 3 syntax
@matthiaskramm matthiaskramm merged commit 335ef31 into python:master Feb 24, 2016
@matthiaskramm
Copy link
Contributor

Merging.

momandine pushed a commit to momandine/typeshed that referenced this pull request Jul 5, 2016
Be explicit about type variables in generic container classes. See is…
37aa1fd 
…sue python#85.
momandine pushed a commit to momandine/typeshed that referenced this pull request Jul 5, 2016
Explain that subclassing e.g. Iterable without a parameter means Iter…
4e248ff 
…able[Any].

This addresses, but does not fix, issue python#85.
hswong3i pushed a commit to alvistack/python-typeshed that referenced this pull request May 25, 2025
@cdce8p
Add better default value for TypeVar default (PEP 696) (python#85)
0dc7304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddfisher @matthiaskramm
0