8000 Add Server to asyncio.base_events' __all__ by vringar · Pull Request #7554 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Add Server to asyncio.base_events' __all__ #7554

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2022
Merged

Add Server to asyncio.base_events' __all__ #7554

merged 3 commits into from
Mar 25, 2022

Conversation

vringar
Copy link
Contributor
@vringar vringar commented Mar 25, 2022

Closes #7552

@vringar
Copy link
Contributor Author
vringar commented Mar 25, 2022 •
edited
Loading

Stub Versioning told me to check for Python 3.10 when checking for a feature introduced in 3.10.3 but this is now failing in CI as they are running against 3.10.2. What should I do? Wait until the tests are updated?

@github-actions

This comment has been minimized.

Sign in to view
srittau
srittau reviewed Mar 25, 2022
View reviewed changes
@JelleZijlstra
Copy link
Member

Stub Versioning told me to check for Python 3.10 when checking for a feature introduced in 3.10.3 but this is now failing in CI as they are running against 3.10.2. What should I do? Wait until the tests are updated?

We can just ignore the error for now by adding to the stubtest allowlist. We can remove that once GH is on 3.10.3.

srittau
srittau reviewed Mar 25, 2022
View reviewed changes
@vringar
Copy link
Contributor Author
vringar commented Mar 25, 2022

I split the import from the __all__ and adjusted for the backport.
So if you want to adjust the Allowlist, I think this is ready

@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja
Copy link
Collaborator

You'll need to add asyncio.base_events.__all__ and asyncio.Server to:
https://github.com/python/typeshed/blob/master/tests/stubtest_allowlists/py39.txt
https://github.com/python/typeshed/blob/master/tests/stubtest_allowlists/py310.txt

@hauntsaninja
Copy link
Collaborator
hauntsaninja commented Mar 25, 2022 •
edited
Loading

(I pushed a commit to mypy_primer to temporarily remove edgedb)

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

AlexWaygood
AlexWaygood approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood merged commit f40747f into python:master Mar 25, 2022
@vringar vringar deleted the asyncio_server branch March 25, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau left review comments

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include Server in __all__ in asyncio.base_events
5 participants
@vringar @JelleZijlstra @hauntsaninja @srittau @AlexWaygood
0