8000 Improve various signatures that shouldn't be `async def`, but currently are by AlexWaygood · Pull Request #7491 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Improve various signatures that shouldn't be async def, but currently are #7491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 19, 2022
Merged

Improve various signatures that shouldn't be async def, but currently are #7491

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bee4f2d
Improve `typing.AsyncIterator` and `typing.AsyncGenerator`
AlexWaygood Mar 14, 2022
6041c28
Fix allowlists
AlexWaygood Mar 14, 2022
3191092
Allow
AlexWaygood Mar 14, 2022
80acd91
Fix `SupportsAnext` & `contextlib._SupportsAclose`.
AlexWaygood Mar 14, 2022
825910a
Use `_typeshed.Anext`
AlexWaygood Mar 15, 2022
e5d3697
Add comment
AlexWaygood Mar 15, 2022
a25aa37
Improve comment
AlexWaygood Mar 15, 2022
748c8e8
Fix allowlist references
AlexWaygood Mar 15, 2022
c08becf
Merge branch 'async-generator' of https://github.com/AlexWaygood/type…
AlexWaygood Mar 15, 2022
6f738dd
Merge branch 'master' into async-generator
AlexWaygood Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow
  • Loading branch information
@AlexWaygood
AlexWaygood committed Mar 14, 2022
commit 319109240c22af6dfbe8041f680c5a3296e47ff1
1 change: 1 addition & 0 deletions tests/stubtest_allowlists/py310.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ typing.IO.truncate
typing.IO.write
typing.IO.writelines

_collections_abc.AsyncGenerator.athrow # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
_weakref.ProxyType.__reversed__ # Doesn't really exist
ast.Bytes.__new__
ast.Ellipsis.__new__
Expand Down
3 changes: 2 additions & 1 deletion tests/stubtest_allowlists/py36.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ builtins.float.__setformat__ # Internal method for CPython test suite
builtins.str.maketrans
cmath.log
collections.AsyncGenerator.asend # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
collections.AsyncGenerator.athrow # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
collections.AsyncGenerator.__anext__ # async at runtime, deliberately not in the stub, see #7475
collections.AsyncGenerator.aclose # async at runtime, deliberately not in the stub, see #7475
collections.AsyncIterator.__anext__ # async at runtime, deliberately not in the stub, see #7475
Expand Down Expand Up @@ -94,6 +93,8 @@ tkinter.filedialog.TkVersion
tkinter.filedialog.wantobjects
tkinter.simpledialog.wantobjects
tkinter.tix.wantobjects
typing.AsyncGenerator.aclose # async at runtime, deliberately not in the stub, see #7475
typing.AsyncGenerator.asend # async at runtime, deliberately not in the stub, see #7475

builtins.memoryview.__iter__ # C type that implements __getitem__
builtins.memoryview.cast # inspect.signature is incorrect about shape being kw-only
Expand Down
1 change: 0 additions & 1 deletion tests/stubtest_allowlists/py37.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ builtins.float.__set_format__ # Internal method for CPython test suite
builtins.str.maketrans
cmath.log
collections.AsyncGenerator.asend # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
collections.AsyncGenerator.athrow # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
collections.AsyncGenerator.__anext__ # async at runtime, deliberately not in the stub, see #7475
collections.AsyncGenerator.aclose # async at runtime, deliberately not in the stub, see #7475
collections.AsyncIterator.__anext__ # async at runtime, deliberately not in the stub, see #7475
Expand Down
1 change: 0 additions & 1 deletion tests/stubtest_allowlists/py38.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ asyncio.locks._ContextManagerMixin.__exit__ # Always raises; deliberately omitt
builtins.dict.get
builtins.float.__set_format__ # Internal method for CPython test suite
collections.AsyncGenerator.asend # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
collections.AsyncGenerator.athrow # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
collections.AsyncGenerator.__anext__ # async at runtime, deliberately not in the stub, see #7475
collections.AsyncGenerator.aclose # async at runtime, deliberately not in the stub, see #7475
collections.AsyncIterator.__anext__ # async at runtime, deliberately not in the stub, see #7475
Expand Down
1 change: 0 additions & 1 deletion tests/stubtest_allowlists/py39.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ asyncio.futures.Future._callbacks # Usually initialized from c object
builtins.dict.get
builtins.float.__set_format__ # Internal method for CPython test suite
collections.AsyncGenerator.asend # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
collections.AsyncGenerator.athrow # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
collections.AsyncGenerator.__anext__ # async at runtime, deliberately not in the stub, see #7475
collections.AsyncGenerator.aclose # async at runtime, deliberately not in the stub, see #7475
collections.AsyncIterator.__anext__ # async at runtime, deliberately not in the stub, see #7475
Expand Down
1 change: 0 additions & 1 deletion tests/stubtest_allowlists/py3_common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,6 @@ xml.parsers.expat.expat_CAPI
# Allowlist entries that cannot or should not be fixed
# ==========
_collections_abc.AsyncGenerator.asend # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
_collections_abc.AsyncGenerator.athrow # async at runtime, deliberately not in the stub, see #7475. Pos-only differences also.
_collections_abc.AsyncGenerator.__anext__ # async at runtime, deliberately not in the stub, see #7475
_collections_abc.AsyncGenerator.aclose # async at runtime, deliberately not in the stub, see #7475
_collections_abc.AsyncIterator.__anext__ # async at runtime, deliberately not in the stub, see #7475
Expand Down
0