8000 Add `__all__` to most modules beginning with 'q', 'r' and 's' by AlexWaygood · Pull Request #7364 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Add __all__ to most modules beginning with 'q', 'r' and 's' #7364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2022
Merged

Add __all__ to most modules beginning with 'q', 'r' and 's' #7364

merged 1 commit into from
Feb 23, 2022

Conversation

AlexWaygood
Copy link
Member

No description provided.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

JelleZijlstra
JelleZijlstra approved these changes Feb 23, 2022
View reviewed changes
stdlib/quopri.pyi
@@ -1,5 +1,7 @@
from typing import BinaryIO

__all__ = ["encode", "decode", "encodestring", "decodestring"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has a comment # (Dec 1991 version)., that module is older than me

stdlib/smtpd.pyi
@@ -4,6 +4,8 @@ import socket
from collections import defaultdict
from typing import Any

__all__ = ["SMTPChannel", "SMTPServer", "DebuggingServer", "PureProxy", "MailmanProxy"]
Copy link
Member

Choose a reason for hiding this co 94B7 mment

The reason will be displayed to describe this comment to others. Learn more.

MailmanProxy is gone in 3.11 (python/cpython#26617). I'll send a separate PR for that.

@JelleZijlstra JelleZijlstra merged commit a3bb5af into python:master Feb 23, 2022
@AlexWaygood AlexWaygood deleted the q-r branch February 23, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWaygood @JelleZijlstra
0