8000 Do not run actions on forks by sobolevn · Pull Request #7074 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Do not run actions on forks #7074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Do not run actions on forks #7074

wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

Closes #7066

@Akuli
Copy link
Collaborator
Akuli commented Feb 5, 2022

As discussed in the issue, there turned out to be one person who strongly dislikes this. If you equally strongly like this, you can disable the actions in your fork's settings. But thanks for bringing this up :)

@Akuli Akuli closed this Feb 5, 2022
@nightlark
Copy link
nightlark commented May 30, 2022 •
edited
Loading

@Akuli most of the reasons for the strong dislikes aren't relevant, since the workflow_dispatch trigger in the workflow file enables easily running the tests in forks in any branch as needed.

I noticed that some of the other workflows (such as the daily scheduled tests) don't have workflow_dispatch listed as a trigger; might be good to get those added in.

@hugovk
Copy link
Member
hugovk commented May 30, 2022

@Akuli most of the reasons for the strong dislikes aren't relevant, since the workflow_dispatch trigger in the workflow file enables easily running the tests in forks in any branch as needed.

It's still relevant.

Sure, it's possible to trigger via workflow_dispatch, but it's still an extra impediment. Making the human do more work so the computer can do less.

As shown in this example screencast, it can take 9 clicks and 25 seconds to trigger each and every build with workflow_dispatch: python/bedevere#461 (comment)

I noticed that some of the other workflows (such as the daily scheduled tests) don't have workflow_dispatch listed as a trigger; might be good to get those added in.

Good idea 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do we need to run actions on forks?
4 participants
@sobolevn @Akuli @nightlark @hugovk
0