Add partial.__new__ #6813
Add partial.__new__ #6813
Conversation
This comment has been minimized.
This comment has been minimized.
* Add partial.__new__: __new__ is necessary for any derived classes that override __new__ and want to call super since new instead of init is defined in the base class. * Remove partial.__init__ since it's not defined. * Make the func parameter positional-only by naming it with double-underscore, as per PEP 484.
|
Nit for future reference: Avoid amending and force-pushing when contributing to typeshed, because after a force-push, it's harder to see what has changed since the previous review. When merging the PR, we will use Github's "Squash and merge" button to combine the whole PR into a single commit on master. |
Thanks for the quick review. I tested that this change fixes my MyPy error here: https://github.com/NeilGirdhar/tjax/blob/master/tjax/_src/partial.py#L57 |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Nice! You may want to add the project to https://github.com/hauntsaninja/mypy_primer so that instead of getting the above "no effect" comment from mypy_primer, we would get something along the lines of "unused type: ignore comment". |
partial.__new__:__new__is necessary for any derived classes thatoverride
__new__and want to call super since__new__instead of__init__isdefined in the base class.
partial.__init__since it's not defined.double-underscore, as per PEP 484.
See: https://github.com/python/cpython/blob/main/Lib/functools.py#L283