8000 Add missing attributes to `contextlib._(Async)GeneratorContextManager` by AlexWaygood · Pull Request #6676 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content
8000

Add missing attributes to contextlib._(Async)GeneratorContextManager #6676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Dec 26, 2021
Merged

Add missing attributes to contextlib._(Async)GeneratorContextManager #6676

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7ed7844
Add `contextlib._GeneratorContextManagerBase`
AlexWaygood Dec 23, 2021
dd4b78b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 23, 2021
8164612
Fix `decorator`
AlexWaygood Dec 23, 2021
f44b73b
Merge branch 'contextlib' of https://github.com/AlexWaygood/typeshed …
AlexWaygood Dec 23, 2021
835335a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 23, 2021
2ddceea
More `decorator` fixes
AlexWaygood Dec 23, 2021
c8b93c0
More `decorator` fixes
AlexWaygood Dec 23, 2021
0c59017
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 23, 2021
6e09569
Fix
AlexWaygood Dec 23, 2021
4953955
Add `type: ignore` for mypy
AlexWaygood Dec 23, 2021
ad6d7fe
Hopefully this will reduce primer diff
AlexWaygood Dec 23, 2021
52e8874
Experiment with using `Iterator` instead of `Generator`
AlexWaygood Dec 23, 2021
3a8fcf9
Unused `TypeVar`s
AlexWaygood Dec 23, 2021
8d1813b
Use `ParamSpec` less
AlexWaygood Dec 23, 2021
2606822
Increase type specificity in base class
AlexWaygood Dec 23, 2021
d1b4ace
Revert changes to `decorator` (irrelevant now that the number of para…
AlexWaygood Dec 23, 2021
7d0db92
Simplify version guards
AlexWaygood Dec 23, 2021
b2cdc57
Remove `_GeneratorContextManagerBase`
AlexWaygood Dec 23, 2021
f21ad01
Remove unused allowlist entry
AlexWaygood Dec 23, 2021
d652c29
Remove use of ParamSpec, for now
AlexWaygood Dec 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Increase type specificity in base class
  • Loading branch information
@AlexWaygood
AlexWaygood committed Dec 23, 2021
commit 2606822d1bf56f3df3dc96d57c7e7f8283a880bd
6 changes: 3 additions & 3 deletions stdlib/contextlib.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ class ContextDecorator:

if sys.version_info >= (3, 7):
class _GeneratorContextManagerBase:
def __init__(self, func: Callable[_P, Any], args: _P.args, kwds: _P.kwds) -> None: ... # type: ignore[name-defined]
gen: Any
func: Callable[..., Any]
def __init__(self, func: Callable[_P, Iterator[Any] | AsyncIterator[Any]], args: _P.args, kwds: _P.kwds) -> None: ... # type: ignore[name-defined]
gen: Generator[Any, Any, Any] | AsyncGenerator[Any, Any]
func: Callable[..., Generator[Any, Any, Any] | AsyncGenerator[Any, Any]]
args: tuple[Any, ...]
kwds: dict[str, Any]
class _GeneratorContextManager(_GeneratorContextManagerBase, AbstractContextManager[_T_co], ContextDecorator, Generic[_T_co]):
Expand Down
0