-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
add pre-commit config #6341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add pre-commit config #6341
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ed11313
add pre-commit config
JelleZijlstra 43a339a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] dc6df29
exclude protobuf harder
JelleZijlstra d50b24c
undo protobuf changes
JelleZijlstra 8afbff4
Update tests/stubtest_third_party.py
JelleZijlstra c66fef5
Update tests/stubtest_third_party.py
JelleZijlstra 091089d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4d2866c
comment that versions must match
JelleZijlstra 39ff6b9
also change CI actions for consistency
JelleZijlstra 48981f9
confused the grep
JelleZijlstra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
repos: | ||
- repo: https://github.com/psf/black | ||
rev: 21.11b1 | ||
hooks: | ||
- id: black | ||
language_version: python3.9 | ||
- repo: https://github.com/pycqa/isort | ||
rev: 5.10.1 | ||
hooks: | ||
- id: isort | ||
name: isort (python) | ||
|
||
ci: | ||
autofix_commit_msg: '[pre-commit.ci] auto fixes from pre-commit.com hooks' | ||
autofix_prs: true | ||
autoupdate_commit_msg: '[pre-commit.ci] pre-commit autoupdate' | ||
autoupdate_schedule: weekly | ||
skip: [] | ||
submodules: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
mypy==0.910 | ||
pytype==2021.11.2; platform_system != "Windows" | ||
black==21.9b0 | ||
black==21.11b1 | ||
flake8==4.0.1 | ||
flake8-bugbear==21.9.2 | ||
flake8-pyi==20.10.0 | ||
isort==5.9.3 | ||
isort==5.10.1 | ||
tomli==1.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a comment about how this version must match
requirements-tests-py3.txt
, ideally in both places. Same for isort.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, done