8000 Improve fpdf.image_parsing by srittau · Pull Request #6313 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Improve fpdf.image_parsing #6313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 16, 2021
Merged

Improve fpdf.image_parsing #6313

merged 2 commits into from
Nov 16, 2021

Conversation

srittau
Copy link
Collaborator
@srittau srittau commented Nov 16, 2021
  • Annotate more attributes, arguments, and return types.
  • Add "dims" argument to get_img_info(), added in 2.4.6.

@srittau
Improve fpdf.image_parsing
847a527 
* Annotate more attributes, arguments, and return types.
* Add "dims" argument to get_img_info(), added in 2.4.6.
@srittau srittau mentioned this pull request Nov 16, 2021
Merged
JelleZijlstra
JelleZijlstra approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was just about to fix the mypy thing :)

@srittau srittau merged commit 1b0e268 into python:master Nov 16, 2021
@srittau srittau deleted the fpdf-2.4.6 branch November 16, 2021 16:35
@srittau
Copy link
Collaborator Author
srittau commented Nov 16, 2021

I've merged this despite the CI failure, to have separate commits for separate third-party packages.

@srittau srittau mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srittau @JelleZijlstra
0