Harmonise return type of `builtins.import` and `importlib.import_module` #6302

AlexWaygood · 2021-11-15T13:56:49Z

github-actions · 2021-11-15T14:07:31Z

AlexWaygood · 2021-11-15T14:09:09Z

srittau

AlexWaygood · 2021-11-15T15:23:16Z

AlexWaygood added 3 commits November 15, 2021 13:49

Harmonise return type of builtins.__import__ and `importlib.import_…

5d0cbff

…module`

tweak builtins

6766142

tweak types.pyi

c36e17f

srittau approved these changes Nov 15, 2021

View reviewed changes

JelleZijlstra approved these changes Nov 15, 2021

View reviewed changes

srittau merged commit aa7e277 into python:master Nov 15, 2021

AlexWaygood deleted the harmonise-import-return branch November 15, 2021 15:22

AlexWaygood mentioned this pull request Nov 15, 2021

builtins.__import__ & importlib.import_module should have the same return type #6295

Closed

BvB93 mentioned this pull request Nov 22, 2021

__array_namespace__ type Hint data-apis/array-api#267

Open

AlexWaygood mentioned this pull request Nov 22, 2021

Remove ModuleType.__getattr__ #6357

Closed

JukkaL mentioned this pull request Nov 23, 2021

Don't use ModuleType.__getattr__ if we know module symbols python/mypy#11597

Merged

AlexWaygood mentioned this pull request Sep 29, 2022

modules as protocols doesn't type-check against the protocol python/mypy#13771

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Harmonise return type of `builtins.import` and `importlib.import_module` #6302

Harmonise return type of `builtins.import` and `importlib.import_module` #6302

Harmonise return type of builtins.__import__ and importlib.import_module #6302

Harmonise return type of builtins.__import__ and importlib.import_module #6302

Conversation

Choose a reason for hiding this comment

Harmonise return type of `builtins.import` and `importlib.import_module` #6302

Harmonise return type of `builtins.import` and `importlib.import_module` #6302