8000 pkg_resources is part of setuptools by srittau · Pull Request #5669 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

pkg_resources is part of setuptools #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2021
Merged

pkg_resources is part of setuptools #5669

merged 2 commits into from
Jun 21, 2021

Conversation

srittau
Copy link
Collaborator
@srittau srittau commented Jun 21, 2021

No description provided.

@srittau srittau mentioned this pull request Jun 21, 2021
Merged
@Akuli
Copy link
Collaborator
Akuli commented Jun 21, 2021

What's going to happen to https://pypi.org/project/types-pkg-resources/ ?

@JukkaL
Copy link
Contributor
JukkaL commented Jun 21, 2021

What's going to happen to https://pypi.org/project/types-pkg-resources/ ?

I assume it will stay on PyPI indefinitely but won't get any updates. Probably it's being used already, and we don't want to break things for users.

JukkaL
JukkaL approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor
@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, pkg_resources seems to be installed by setuptools and there is no PyPI package called `pkg_resources.

@JukkaL JukkaL merged commit a319ba4 into python:master Jun 21, 2021
@JelleZijlstra
Copy link
Member

But if people install both pkg_resources-types and setuptools-types, both packages will install into the same directory (pkg_resources-stubs). That could lead to confusing behavior.

JukkaL pushed a commit to python/mypy that referenced this pull request Jun 21, 2021
@srittau
pkg_resources is now in types-setuptools (#10681)
ac2cace 
Depends on python/typeshed#5669
@JukkaL
Copy link
Contributor
JukkaL commented Jun 21, 2021

@JelleZijlstra That's a fair point. The original project name was plain wrong though, so perhaps we just need to live with it. Alternatively, we could upload a new version of types-pkg-resources that is empty and just depends on types-setuptools.

@srittau srittau deleted the setuptools branch June 21, 2021 16:32
@srittau
Copy link
Collaborator Author
srittau commented Jun 21, 2021

I was thinking about this before, especially in relation to the other packages we renamed, and basically had the same idea as Jukka. We should probably add a small script to stub_uploader which we can use to generate "renamed" packages consistently. Maybe something similar for removed packages, where types are now shipped upstream.

JukkaL pushed a commit to python/mypy that referenced this pull request Jun 22, 2021
@srittau @JukkaL
pkg_resources is now in types-setuptools (#10681)
64deb99 
Depends on python/typeshed#5669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL JukkaL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@srittau @Akuli @JukkaL @JelleZijlstra
0