10000 Itertools stubtest exception fixes / adjustments by hatal175 · Pull Request #5211 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Itertools stubtest exception fixes / adjustments #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 12, 2021
Merged

Itertools stubtest exception fixes / adjustments #5211

merged 6 commits into from
Apr 12, 2021

Conversation

hatal175
Copy link
Contributor
  1. Fixed itertools stubtest exceptions
  2. Mostly classes defined as functions (see Functions that are actually classes #5145)
  3. Did not fix product and combinations due to Tuple mypy issues. see Incompatible return type for overlapping signatures with regards to __new__ mypy#10313
  4. Tried to make count more accurate as it technically can accept anything that passes PyNumber_Check and has add. There also isn't a need to tie the start and step together type-wise.

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

sphinx (https://github.com/sphinx-doc/sphinx.git)
+ sphinx/pycode/parser.py: note: In member "add_entry" of class "VariableCommentPicker":
+ sphinx/pycode/parser.py:252:50: error: Incompatible types in assignment (expression has type "SupportsComplex", target has type "int")
+ sphinx/pycode/parser.py: note: At top level:

srittau
srittau approved these changes Apr 12, 2021
View reviewed changes
Copy link
Collaborator
@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@srittau srittau merged commit 7adb021 into python:master Apr 12, 2021
@Akuli Akuli mentioned this pull request May 7, 2021
Closed
@nipunn1313 nipunn1313 mentioned this pull request Aug 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hatal175 @srittau
0