Add a suggestion to CONTRIBUTING.md #5205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this in #5204. This is already our de facto convention. I think it's confusing enough if not followed that it makes sense to standardize on this rule. Should we add an example? It might be useful but it's not in line with the rest of the section.
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Apr 11, 2021
Since we're adding this to our contribution guidelines in python#5205
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Apr 11, 2021
Since we're adding this to our contribution guidelines in python#5205
Akuli
approved these changes
Apr 11, 2021
JelleZijlstra
pushed a commit
that referenced
this pull request
Apr 11, 2021
Since we're adding this to our contribution guidelines in #5205
srittau
approved these changes
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this in #5204. This is already our de facto convention. I think it's confusing enough if not followed that it makes sense to standardize on this rule.
Should we add an example? It might be useful but it's not in line with the rest of the section.