8000 Name2 by melassa · Pull Request #4867 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Name2 #4867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2020
Merged

Name2 #4867

merged 2 commits into from
Dec 28, 2020

Conversation

melassa
Copy link
Contributor
@melassa melassa commented Dec 28, 2020 •
edited
Loading

#4658
Added a name parameter to tk and ttk widgets

Akuli
Akuli requested changes Dec 28, 2020
View reviewed changes
Copy link
Collaborator
@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ttk.Spinbox and ttk.LabeledScale also seem to support name, but it's missing from the stubs.

Akuli
Akuli approved these changes Dec 28, 2020
View reviewed changes
Copy link
Collaborator
@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous review was wrong. This does add the name to Spinbox and I just missed it with grep. LabeledScale keyword arguments are currently **kw: Any.

srittau
srittau approved these changes Dec 28, 2020
View reviewed changes
Copy link
Collaborator
@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Akuli

@srittau srittau merged commit 350095e into python:master Dec 28, 2020
@Akuli Akuli mentioned this pull request Dec 28, 2020
Closed
@melassa melassa deleted the name2 branch December 29, 2020 10:04
@Akuli Akuli mentioned this pull request Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srittau srittau srittau approved these changes

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melassa @srittau @Akuli
0