8000 Added missing type annotations for fractions and numbers modules. by erictraut · Pull Request #4401 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Added missing type annotations for fractions and numbers modules. #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 16, 2020
Merged

Added missing type annotations for fractions and numbers modules. #4401

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f37062d
Added missing type annotations for fractions and numbers modules.
msfterictraut Aug 6, 2020
a2c18e6
Fixed bad annotation for self.
msfterictraut Aug 7, 2020
48513a8
Worked around error emitted by mypy.
msfterictraut Aug 7, 2020
86f5ea5
Fixed another issue found in CI test.
msfterictraut Aug 7, 2020
23fa7d5
Removed extra line at bottom of file that my auto-formatter keeps add…
msfterictraut Aug 7, 2020
f7d16ab
Incorporated code review feedback. Did a bunch of experimentation wit…
msfterictraut Aug 8, 2020
c90aa22
Adjusted base class abstract method signatures.
msfterictraut Aug 8, 2020
52a2353
Fixed error caught by test.
msfterictraut Aug 8, 2020
596edbd
Removed unnecessary overload.
msfterictraut Aug 8, 2020
c1b7f4a
Fixed error in __round__ identified by stubtest.
msfterictraut Aug 8, 2020
ad863f7
Made changes based on PR feedback.
msfterictraut Aug 11, 2020
911e8f9
Fixed overload ordering issue
msfterictraut Aug 11, 2020
1f280ca
Fixed more stubtest errors
msfterictraut Aug 11, 2020
55755f6
Missed one more overload order issue
msfterictraut Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed error in __round__ identified by stubtest.
  • Loading branch information
@msfterictraut
msfterictraut committed Aug 8, 2020
commit c1b7f4aa73e48abceffb727eb8cfdeac30407ba2
4 changes: 2 additions & 2 deletions stdlib/2and3/fractions.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ class Fraction(Rational):
def __floor__(self) -> int: ...
def __ceil__(self) -> int: ...
@overload
def __round__(self) -> int: ...
@overload
def __round__(self, ndigits: int) -> Fraction: ...
@overload
def __round__(self, ndigits: None = ...) -> int: ...
def __hash__(self) -> int: ...
def __eq__(self, other: object) -> bool: ...
def __lt__(self, other: _ComparableNum) -> bool: ...
Expand Down
4 changes: 2 additions & 2 deletions stdlib/2and3/numbers.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,10 @@ class Real(Complex, SupportsFloat):
def __ceil__(self) -> int: ...
@abstractmethod
@overload
def __round__(self) -> int: ...
def __round__(self: _T, ndigits: int) -> _T: ...
@abstractmethod
@overload
def __round__(self: _T, ndigits: int) -> _T: ...
def __round__(self, ndigits: None = ...) -> int: ...
def __divmod__(self, other: Any) -> Any: ...
def __rdivmod__(self, other: Any) -> Any: ...
@abstractmethod
Expand Down
0