8000 Remove tuple's __init__ method by msullivan · Pull Request #2467 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Remove tuple's __init__ method#2467

Merged
JelleZijlstra merged 2 commits intomasterfrom
no-tuple-init
Sep 19, 2018
Merged

Remove tuple's __init__ method#2467
JelleZijlstra merged 2 commits intomasterfrom
no-tuple-init

Conversation

@msullivan
Copy link
Contributor
@msullivan msullivan commented Sep 19, 2018 •
edited
Loading

The __new__ method should suffice, and having both interferes with providing
a __new__ in namedtuples, which we want to do to fix
python/mypy#1279.

@msullivan
Remove tuple's __init__ method
722b23d 
The __new__ method should suffice, and having both interferes with providing
a __new__ in namedtuples, which we want to do to fix
python/mypy#1279.
@msullivan
update __builtin__.pyi also
e4f323f
@msullivan
Copy link
Contributor Author
msullivan commented Sep 19, 2018

Though actually the problem only comes up because of python/mypy#1435, so it is probably worth fixing that.

tuple doesn't have a __init__ method, though, so kind of no reason to not land this if it doesn't break anything.

@JelleZijlstra JelleZijlstra merged commit 4f4a025 into master Sep 19, 2018
@JelleZijlstra JelleZijlstra deleted the no-tuple-init branch September 19, 2018 03:01
@gvanrossum gvanrossum mentioned this pull request Sep 19, 2018
Closed
@gvanrossum
Copy link
Member
gvanrossum commented Sep 19, 2018

(Also I think in general mypy should in general allow redundant __new__ and __init__ methods, as long as the signatures match or at least overlap. After all if we have annotations in the code there may be legitimate cases that define both. However, tuple doesn't actually have __init__, only __new__, so this PR is still the right thing.)

yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@msullivan
Remove tuple's __init__ method (python#2467)
19c2ba5 
The __new__ method should suffice, and having both interferes with providing
a __new__ in namedtuples, which we want to do to fix
python/mypy#1279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msullivan @gvanrossum @JelleZijlstra
0