Remove tuple's __init__ method #2467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __new__ method should suffice, and having both interferes with providing a __new__ in namedtuples, which we want to do to fix python/mypy#1279.
Contributor
Author
|
Though actually the problem only comes up because of python/mypy#1435, so it is probably worth fixing that. tuple doesn't have a |
JelleZijlstra
approved these changes
Sep 19, 2018
Member
|
(Also I think in general mypy should in general allow redundant |
yedpodtrzitko
pushed a commit
to yedpodtrzitko/typeshed
that referenced
this pull request
Jan 23, 2019
The __new__ method should suffice, and having both interferes with providing a __new__ in namedtuples, which we want to do to fix python/mypy#1279.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__new__method should suffice, and having both interferes with providinga
__new__in namedtuples, which we want to do to fixpython/mypy#1279.