8000 Future.set_running_or_notify_cancel returns bool by li-dan · Pull Request #1911 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Future.set_running_or_notify_cancel returns bool #1911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2018
Merged

Future.set_running_or_notify_cancel returns bool #1911

merged 1 commit into from
Feb 22, 2018

Conversation

li-dan
Copy link
Contributor
@li-dan li-dan commented Feb 22, 2018

Future.set_running_or_notify_cancel returns a bool, not None. See commit
13bcc79, where this problem was fixed
for Python 2.

Future.set_running_or_notify_cancel returns bool
fe2319d 
Future.set_running_or_notify_cancel returns a bool, not None. See commit
13bcc79, where this problem was fixed
for Python 2.
@JelleZijlstra JelleZijlstra merged commit 2c62960 into python:master Feb 22, 2018
@li-dan li-dan deleted the future_set_running_or_notify_cancel branch June 11, 2018 15:30
li-dan pushed a commit to li-dan/typeshed that referenced this pull request Jun 15, 2018
Make concurrent.futures stubs identical
a13e3ad 
Make the Python 2 and 3 concurrent.futures stubs identical so fixes get
applied to both.

For example, python#1305 and python#2233 fixed the same problem at differnt times,
as did python#1078 and python#1911.

By making the stubs identical, we apply the fix from python#1711 to Python 2.

Fixes python#2234.
@li-dan li-dan mentioned this pull request Jun 15, 2018
Merged
li-dan pushed a commit to li-dan/typeshed that referenced this pull request Jun 15, 2018
Make concurrent.futures stubs identical
6dffb39 
Make the Python 2 and 3 concurrent.futures stubs identical so fixes get
applied to both.

For example, python#1305 and python#2233 fixed the same problem at different times,
as did python#1078 and python#1911.

By making the stubs identical, we apply the fix from python#1711 to Python 2.

Fixes python#2234.
JelleZijlstra pushed a commit that referenced this pull request Jun 15, 2018
@li-dan @JelleZijlstra
Make concurrent.futures stubs identical (#2237)
5054465 
Make the Python 2 and 3 concurrent.futures stubs identical so fixes get
applied to both.

For example, #1305 and #2233 fixed the same problem at different times,
as did #1078 and #1911.

By making the stubs identical, we apply the fix from #1711 to Python 2.

Fixes #2234.
yedpodtrzitko pushed a commit to yedpodtrzitko/typeshed that referenced this pull request Jan 23, 2019
@li-dan
Make concurrent.futures stubs identical (python#2237)
41ffa1c 
Make the Python 2 and 3 concurrent.futures stubs identical so fixes get
applied to both.

For example, python#1305 and python#2233 fixed the same problem at different times,
as did python#1078 and python#1911.

By making the stubs identical, we apply the fix from python#1711 to Python 2.

Fixes python#2234.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@li-dan @JelleZijlstra
0