Update nx_pylab.pyi: allow node_color to be a list of strings as well#14057
Merged
srittau merged 5 commits intopython:mainfrom May 14, 2025
wyattscarpenter:patch-1
Merged
Update nx_pylab.pyi: allow node_color to be a list of strings as well#14057srittau merged 5 commits intopython:mainfrom wyattscarpenter:patch-1
srittau merged 5 commits intopython:mainfrom
wyattscarpenter:patch-1
Conversation
As per the documentation https://networkx.org/documentation/latest/reference/generated/networkx.drawing.nx_pylab.draw_networkx_nodes.html#draw-networkx-nodes and program behavior. I'm actually using version 2 of this library, 2 majors behind, and it accepts list[str] as well there as well!
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
May 14, 2025
Collaborator
There was a problem hiding this comment.
Thanks, one remark below.
Co-authored-by: Sebastian Rittau <srittau@rittau.biz>
srittau
approved these changes
May 14, 2025
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the documentation https://networkx.org/documentation/latest/reference/generated/networkx.drawing.nx_pylab.draw_networkx_nodes.html#draw-networkx-nodes and program behavior.
Fun fact: I'm actually using version 2 of this library, 2 majors behind, and it accepts list[str] as well there as well!