-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Improve pywin32.isapi
#13889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve pywin32.isapi
#13889
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2bdfda2
Improve `pywin32.isapi`
donBarbos 19bd170
Fix one error
donBarbos 38974dc
Try fix again
donBarbos 2210b5d
Apply suggestions from code review
donBarbos 4e9d360
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8859a73
Correct imports
donBarbos 5e6a2d7
Update install.pyi
donBarbos 96a3d56
Revert "Update install.pyi"
Avasam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,86 +1,86 @@ | ||
from _typeshed import Incomplete | ||
from typing import Final | ||
|
||
HTTP_CONTINUE: int | ||
HTTP_SWITCHING_PROTOCOLS: int | ||
HTTP_PROCESSING: int | ||
HTTP_OK: int | ||
HTTP_CREATED: int | ||
HTTP_ACCEPTED: int | ||
HTTP_NON_AUTHORITATIVE: int | ||
HTTP_NO_CONTENT: int | ||
HTTP_RESET_CONTENT: int | ||
HTTP_PARTIAL_CONTENT: int | ||
HTTP_MULTI_STATUS: int | ||
HTTP_MULTIPLE_CHOICES: int | ||
HTTP_MOVED_PERMANENTLY: int | ||
HTTP_MOVED_TEMPORARILY: int | ||
HTTP_SEE_OTHER: int | ||
HTTP_NOT_MODIFIED: int | ||
HT ED4F TP_USE_PROXY: int | ||
HTTP_TEMPORARY_REDIRECT: int | ||
HTTP_BAD_REQUEST: int | ||
HTTP_UNAUTHORIZED: int | ||
HTTP_PAYMENT_REQUIRED: int | ||
HTTP_FORBIDDEN: int | ||
HTTP_NOT_FOUND: int | ||
HTTP_METHOD_NOT_ALLOWED: int | ||
HTTP_NOT_ACCEPTABLE: int | ||
HTTP_PROXY_AUTHENTICATION_REQUIRED: int | ||
HTTP_REQUEST_TIME_OUT: int | ||
HTTP_CONFLICT: int | ||
HTTP_GONE: int | ||
HTTP_LENGTH_REQUIRED: int | ||
HTTP_PRECONDITION_FAILED: int | ||
HTTP_REQUEST_ENTITY_TOO_LARGE: int | ||
HTTP_REQUEST_URI_TOO_LARGE: int | ||
HTTP_UNSUPPORTED_MEDIA_TYPE: int | ||
HTTP_RANGE_NOT_SATISFIABLE: int | ||
HTTP_EXPECTATION_FAILED: int | ||
HTTP_UNPROCESSABLE_ENTITY: int | ||
HTTP_INTERNAL_SERVER_ERROR: int | ||
HTTP_NOT_IMPLEMENTED: int | ||
HTTP_BAD_GATEWAY: int | ||
HTTP_SERVICE_UNAVAILABLE: int | ||
HTTP_GATEWAY_TIME_OUT: int | ||
HTTP_VERSION_NOT_SUPPORTED: int | ||
HTTP_VARIANT_ALSO_VARIES: int | ||
HSE_STATUS_SUCCESS: int | ||
HSE_STATUS_SUCCESS_AND_KEEP_CONN: int | ||
HSE_STATUS_PENDING: int | ||
HSE_STATUS_ERROR: int | ||
SF_NOTIFY_SECURE_PORT: int | ||
SF_NOTIFY_NONSECURE_PORT: int | ||
SF_NOTIFY_READ_RAW_DATA: int | ||
SF_NOTIFY_PREPROC_HEADERS: int | ||
SF_NOTIFY_AUTHENTICATION: int | ||
SF_NOTIFY_URL_MAP: int | ||
SF_NOTIFY_ACCESS_DENIED: int | ||
SF_NOTIFY_SEND_RESPONSE: int | ||
SF_NOTIFY_SEND_RAW_DATA: int | ||
SF_NOTIFY_LOG: int | ||
SF_NOTIFY_END_OF_REQUEST: int | ||
SF_NOTIFY_END_OF_NET_SESSION: int | ||
SF_NOTIFY_ORDER_HIGH: int | ||
SF_NOTIFY_ORDER_MEDIUM: int | ||
SF_NOTIFY_ORDER_LOW: int | ||
SF_NOTIFY_ORDER_DEFAULT: int | ||
SF_NOTIFY_ORDER_MASK: Incomplete | ||
SF_STATUS_REQ_FINISHED: int | ||
SF_STATUS_REQ_FINISHED_KEEP_CONN: Incomplete | ||
SF_STATUS_REQ_NEXT_NOTIFICATION: Incomplete | ||
SF_STATUS_REQ_HANDLED_NOTIFICATION: Incomplete | ||
SF_STATUS_REQ_ERROR: Incomplete | ||
SF_STATUS_REQ_READ_NEXT: Incomplete | ||
HSE_IO_SYNC: int | ||
HSE_IO_ASYNC: int | ||
HSE_IO_DISCONNECT_AFTER_SEND: int | ||
HSE_IO_SEND_HEADERS: int | ||
HSE_IO_NODELAY: int | ||
HSE_IO_FINAL_SEND: int | ||
HSE_IO_CACHE_RESPONSE: int | ||
HSE_EXEC_URL_NO_HEADERS: int | ||
HSE_EXEC_URL_IGNORE_CURRENT_INTERCEPTOR: int | ||
HSE_EXEC_URL_IGNORE_VALIDATION_AND_RANGE: int | ||
HSE_EXEC_URL_DISABLE_CUSTOM_ERROR: int | ||
HSE_EXEC_URL_SSI_CMD: int | ||
HSE_EXEC_URL_HTTP_CACHE_ELIGIBLE: int | ||
HTTP_CONTINUE: Final = 100 | ||
HTTP_SWITCHING_PROTOCOLS: Final = 101 | ||
HTTP_PROCESSING: Final = 102 | ||
HTTP_OK: Final = 200 | ||
HTTP_CREATED: Final = 201 | ||
HTTP_ACCEPTED: Final = 202 | ||
HTTP_NON_AUTHORITATIVE: Final = 203 | ||
HTTP_NO_CONTENT: Final = 204 | ||
HTTP_RESET_CONTENT: Final = 205 | ||
HTTP_PARTIAL_CONTENT: Final = 206 | ||
HTTP_MULTI_STATUS: Final = 207 | ||
HTTP_MULTIPLE_CHOICES: Final = 300 | ||
HTTP_MOVED_PERMANENTLY: Final = 301 | ||
HTTP_MOVED_TEMPORARILY: Final = 302 | ||
HTTP_SEE_OTHER: Final = 303 | ||
HTTP_NOT_MODIFIED: Final = 304 | ||
HTTP_USE_PROXY: Final = 305 | ||
HTTP_TEMPORARY_REDIRECT: Final = 307 | ||
HTTP_BAD_REQUEST: Final = 400 | ||
HTTP_UNAUTHORIZED: Final = 401 | ||
HTTP_PAYMENT_REQUIRED: Final = 402 | ||
HTTP_FORBIDDEN: Final = 403 | ||
HTTP_NOT_FOUND: Final = 404 | ||
HTTP_METHOD_NOT_ALLOWED: Final = 405 | ||
HTTP_NOT_ACCEPTABLE: Final = 406 | ||
HTTP_PROXY_AUTHENTICATION_REQUIRED: Final = 407 | ||
HTTP_REQUEST_TIME_OUT: Final = 408 | ||
HTTP_CONFLICT: Final = 409 | ||
HTTP_GONE: Final = 410 | ||
HTTP_LENGTH_REQUIRED: Final = 411 | ||
HTTP_PRECONDITION_FAILED: Final = 412 | ||
HTTP_REQUEST_ENTITY_TOO_LARGE: Final = 413 | ||
HTTP_REQUEST_URI_TOO_LARGE: Final = 414 | ||
HTTP_UNSUPPORTED_MEDIA_TYPE: Final = 415 | ||
HTTP_RANGE_NOT_SATISFIABLE: Final = 416 | ||
HTTP_ 1E79 EXPECTATION_FAILED: Final = 417 | ||
HTTP_UNPROCESSABLE_ENTITY: Final = 422 | ||
HTTP_INTERNAL_SERVER_ERROR: Final = 500 | ||
HTTP_NOT_IMPLEMENTED: Final = 501 | ||
HTTP_BAD_GATEWAY: Final = 502 | ||
HTTP_SERVICE_UNAVAILABLE: Final = 503 | ||
HTTP_GATEWAY_TIME_OUT: Final = 504 | ||
HTTP_VERSION_NOT_SUPPORTED: Final = 505 | ||
HTTP_VARIANT_ALSO_VARIES: Final = 506 | ||
HSE_STATUS_SUCCESS: Final = 1 | ||
HSE_STATUS_SUCCESS_AND_KEEP_CONN: Final = 2 | ||
HSE_STATUS_PENDING: Final = 3 | ||
HSE_STATUS_ERROR: Final = 4 | ||
SF_NOTIFY_SECURE_PORT: Final = 0x00000001 | ||
SF_NOTIFY_NONSECURE_PORT: Final = 0x00000002 | ||
SF_NOTIFY_READ_RAW_DATA: Final = 0x00008000 | ||
SF_NOTIFY_PREPROC_HEADERS: Final = 0x00004000 | ||
SF_NOTIFY_AUTHENTICATION: Final = 0x00002000 | ||
SF_NOTIFY_URL_MAP: Final = 0x00001000 | ||
SF_NOTIFY_ACCESS_DENIED: Final = 0x00000800 | ||
SF_NOTIFY_SEND_RESPONSE: Final = 0x00000040 | ||
SF_NOTIFY_SEND_RAW_DATA: Final = 0x00000400 | ||
SF_NOTIFY_LOG: Final = 0x00000200 | ||
SF_NOTIFY_END_OF_REQUEST: Final = 0x00000080 | ||
SF_NOTIFY_END_OF_NET_SESSION: Final = 0x00000100 | ||
SF_NOTIFY_ORDER_HIGH: Final = 0x00080000 | ||
SF_NOTIFY_ORDER_MEDIUM: Final = 0x00040000 | ||
SF_NOTIFY_ORDER_LOW: Final = 0x00020000 | ||
SF_NOTIFY_ORDER_DEFAULT: Final = SF_NOTIFY_ORDER_LOW | ||
SF_NOTIFY_ORDER_MASK: Final = 917504 | ||
SF_STATUS_REQ_FINISHED: Final = 134217728 | ||
SF_STATUS_REQ_FINISHED_KEEP_CONN: Final = 134217729 | ||
SF_STATUS_REQ_NEXT_NOTIFICATION: Final = 134217730 | ||
SF_STATUS_REQ_HANDLED_NOTIFICATION: Final = 134217731 | ||
SF_STATUS_REQ_ERROR: Final = 134217732 | ||
SF_STATUS_REQ_READ_NEXT: Final = 134217733 | ||
HSE_IO_SYNC: Final = 0x00000001 | ||
HSE_IO_ASYNC: Final = 0x00000002 | ||
HSE_IO_DISCONNECT_AFTER_SEND: Final = 0x00000004 | ||
HSE_IO_SEND_HEADERS: Final = 0x00000008 | ||
HSE_IO_NODELAY: Final = 0x00001000 | ||
HSE_IO_FINAL_SEND: Final = 0x00000010 | ||
HSE_IO_CACHE_RESPONSE: Final = 0x00000020 | ||
HSE_EXEC_URL_NO_HEADERS: Final = 0x02 | ||
HSE_EXEC_URL_IGNORE_CURRENT_INTERCEPTOR: Final = 0x04 | ||
HSE_EXEC_URL_IGNORE_VALIDATION_AND_RANGE: Final = 0x10 | ||
HSE_EXEC_URL_DISABLE_CUSTOM_ERROR: Final = 0x20 | ||
HSE_EXEC_URL_SSI_CMD: Final = 0x40 | ||
HSE_EXEC_URL_HTTP_CACHE_ELIGIBLE: Final = 0x80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be sync with the
log
function?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Yeah.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donBarbos My bad. I answered too fast. Here it means "this function expects to be passed a
log
parameter that should be a function that accepts astr
as the 2nd parameter".In other words, we want to ensure that whatever function will be passed here will work once a string is passed. The typing here is based on usage, it's completely separate from
isapi.isntall.log
I went ahead and reverted the last commit.