8000 Remove `webbrowser.MacOSX` for Python 3.13 by max-muoto · Pull Request #12390 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Remove webbrowser.MacOSX for Python 3.13 #12390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 21, 2024
Merged

Remove webbrowser.MacOSX for Python 3.13 #12390

merged 5 commits into from
Jul 21, 2024

Conversation

max-muoto
Copy link
Contributor

Remove for 3.13, add deprecation warning for 3.11+: python/cpython#104804

@max-muoto max-muoto force-pushed the deprecate-webbrowswer-macosx branch from 0462e14 to 0a55a3f Compare July 21, 2024 01:37
@max-muoto max-muoto changed the title Remove MacOSX for Python 3.13 Remove webbrowser.MacOSX for Python 3.13 Jul 21, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja requested changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator
@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we usually don't version deprecations. This lets us time travel in a way CPython cannot :-)

@max-muoto
Copy link
Contributor Author

Thanks! I think we usually don't version deprecations. This lets us time travel in a way CPython cannot :-)

Thanks, fixed!

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit b6c089d into python:main Jul 21, 2024
63 checks passed
max-muoto added a commit to max-muoto/typeshed that referenced this pull request Jul 23, 2024
@max-muoto
Remove webbrowser.MacOSX for Python 3.13 (python#12390)
c54f6c5
max-muoto added a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
@max-muoto
Remove webbrowser.MacOSX for Python 3.13 (python#12390)
ec63756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-muoto @hauntsaninja @JelleZijlstra
0