8000 Update `dircmp` for 3.13 by max-muoto · Pull Request #12337 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Update dircmp for 3.13 #12337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 5, 2024
Merged

Update dircmp for 3.13 #12337

merged 5 commits into from
Aug 5, 2024

Conversation

max-muoto
Copy link
Contributor

Add shallow argument: python/cpython#109499

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
JelleZijlstra
JelleZijlstra approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right but we may want to make this param keyword-only: python/cpython#57141 (comment)

@hauntsaninja hauntsaninja added the status: deferred Issue or PR deferred until some precondition is fixed label Jul 20, 2024
JelleZijlstra
JelleZijlstra reviewed Jul 21, 2024
View reviewed changes
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@max-muoto @JelleZijlstra
Update stdlib/filecmp.pyi
5838c2b 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Aug 3, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@max-muoto
Copy link
Contributor Author

@JelleZijlstra We should be able to go ahead with merging this now.

@hauntsaninja hauntsaninja merged commit 3c7ffb1 into python:main Aug 5, 2024
63 checks passed
max-muoto added a commit to max-muoto/typeshed that referenced this pull request Aug 17, 2024
@max-muoto
Update dircmp for 3.13 (python#12337)
7c0471d
max-muoto added a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
@max-muoto
Update dircmp for 3.13 (python#12337)
353f37d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
status: deferred Issue or PR deferred until some precondition is fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-muoto @JelleZijlstra @hauntsaninja
0