8000 Fix false positives from `@deprecated` for `shutil.rmtree` by AlexWaygood · Pull Request #12116 · python/typeshed · GitHub
[go: up one dir, main page]

Skip to content

Fix false positives from @deprecated for shutil.rmtree #12116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

AlexWaygood
Copy link
Member
  • Adjust wording: the onerror parameter is no longer expected to be removed in Python 3.14
  • Fix it so that type checkers only emit an error if an argument is actually passed for the onerror parameter. If no argument is passed, there's no need for type checkers to emit a diagnostic.

Fixes #12103

Copy link
Contributor
github-actions bot commented Jun 8, 2024

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 7fc9d65 into python:main Jun 8, 2024
63 checks passed
@AlexWaygood AlexWaygood deleted the shutil-false-pos branch June 8, 2024 19:28
@Avasam
Copy link
Collaborator
Avasam commented Jun 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for shutil.rmtree for python 3.12
3 participants
0