Extend itertools.product to 10 arguments #12023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typing errors when itertools.product is called with more than 6 arguments.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
May 29, 2024
max-muoto
pushed a commit
to max-muoto/typeshed
that referenced
this pull request
Sep 8, 2024
muxator
added a commit
to muxator/typeshed
that referenced
this pull request
Feb 11, 2025
Before this change, the maximum usable arity for itertools.product() was 10 (increased in 2e83e65, python#12023, which raised it from 6 to 10). Fixes python#13490, albeit partially: just based on this change, a user has no way of knowing if he is hitting this limit or not. This discoverability problem will probably be best addressed with changes in documentation or in the type checkers.
muxator
pushed a commit
to muxator/typeshed
that referenced
this pull request
Feb 11, 2025
Before this change, the maximum usable arity for itertools.product() was 10 (increased in 2e83e65, python#12023, which raised it from 6 to 10). Fixes python#13490, albeit partially: just based on this change, a user has no way of knowing if he is hitting this limit or not. This discoverability problem will probably be best addressed with changes in documentation or in the type checkers.
muxator
pushed a commit
to muxator/typeshed
that referenced
this pull request
Feb 11, 2025
Before this change, the maximum usable arity for itertools.product() was 10 (increased in 2e83e65, python#12023, which raised it from 6 to 10). Fixes python#13490, albeit partially: just based on this change, a user has no way of knowing if he is hitting this limit or not. This discoverability problem will probably be best addressed with changes in documentation or in the type checkers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typing errors when itertools.product is called with more than 6 arguments.