8000 Make syslog `setlogmask`, `LOG_MASK` and `LOG_UPTO` positional-only by aminalaee · Pull Request #10756 · python/typeshed · GitHub
[go: up one dir, main page]

Skip to content

Make syslog setlogmask, LOG_MASK and LOG_UPTO positional-only #10756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

aminalaee
Copy link
Contributor
@aminalaee aminalaee commented Sep 24, 2023

Runtime argument has changed for the functions in Python3.12+.
Not sure if it makes sense to follow #6812 and make it positional-only here or have different signatures.

@aminalaee aminalaee force-pushed the update-syslog-allowlist branch from 8741a6a to 562ec39 Compare September 24, 2023 09:38
@aminalaee aminalaee changed the title Update Python 3.12 allowlist Make syslog setlogmask, LOG_MASK and LOG_UPTO positional-only Python 3.12+ Sep 24, 2023
@aminalaee aminalaee changed the title Make syslog setlogmask, LOG_MASK and LOG_UPTO positional-only Python 3.12+ Make syslog setlogmask, LOG_MASK and LOG_UPTO positional-only Sep 24, 2023
@aminalaee aminalaee marked this pull request as ready for review September 24, 2023 09:42
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Copy link
Member
@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Weird that stubtest wasn't emitting an error on Python <3.12, but it does indeed seem like these have always been positional-only

@AlexWaygood AlexWaygood merged commit 8c4dd38 into python:main Sep 24, 2023
@aminalaee aminalaee deleted the update-syslog-allowlist branch September 24, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0