10000 Tighten tempfile() return types by srittau · Pull Request #10232 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

Tighten tempfile() return types #10232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 8, 2023
Merged

Tighten tempfile() return types #10232

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
19da99c
Tighten tempfile() return types
srittau May 30, 2023
3aefbe5
Use mode type aliases from _typeshed
srittau May 31, 2023
2e54629
Make tempfile overloads match open()
srittau May 31, 2023
48177f6
Fix return type
srittau May 31, 2023
a163aad
Fix defaults
srittau May 31, 2023
67ebbcc
Merge branch 'main' into tempfile-ret
srittau Jun 7, 2023
2b80949
Remove unnecessary type alias
srittau Jun 7, 2023
1091571
Python 3.12 updates
srittau Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 46 additions & 22 deletions stdlib/tempfile.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,14 @@ TMP_MAX: int
tempdir: str | None
template: str

_StrMode: TypeAlias = Literal["r", "w", "a", "x", "r+", "w+", "a+", "x+", "rt", "wt", "at", "xt", "r+t", "w+t", "a+t", "x+t"]
_BytesMode: TypeAlias = Literal["rb", "wb", "ab", "xb", "r+b", "w+b", "a+b", "x+b"]
_TextMode: TypeAlias = Literal["r", "w", "a", "x", "r+", "w+", "a+", "x+", "rt", "wt", "at", "xt", "r+t", "w+t", "a+t", "x+t"]
_BinaryMode: TypeAlias = Literal["rb", "wb", "ab", "xb", "r+b", "w+b", "a+b", "x+b"]
_BytesMode: TypeAlias = _BinaryMode # temp backwards compatibility for aiofiles # noqa: Y047

if sys.version_info >= (3, 8):
@overload
def NamedTemporaryFile(
mode: _StrMode,
mode: _TextMode,
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand All @@ -49,7 +50,7 @@ if sys.version_info >= (3, 8):
) -> _TemporaryFileWrapper[str]: ...
@overload
def NamedTemporaryFile(
mode: _BytesMode = "w+b",
mode: _BinaryMode = "w+b",
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand Down Expand Up @@ -77,7 +78,7 @@ if sys.version_info >= (3, 8):
else:
@overload
def NamedTemporaryFile(
mode: _StrMode,
mode: _TextMode,
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand All @@ -88,7 +89,7 @@ else:
) -> _TemporaryFileWrapper[str]: ...
@overload
def NamedTemporaryFile(
mode: _BytesMode = "w+b",
mode: _BinaryMode = "w+b",
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand All @@ -112,10 +113,11 @@ else:
if sys.platform == "win32":
TemporaryFile = NamedTemporaryFile
else:
# See the comments for builtins.open() for an explanation of the overloads.
if sys.version_info >= (3, 8):
@overload
def TemporaryFile(
mode: _StrMode,
mode: _TextMode,
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand All @@ -124,19 +126,31 @@ else:
dir: GenericPath[AnyStr] | None = None,
*,
errors: str | None = None,
) -> IO[str]: ...
) -> io.TextIOWrapper: ...
@overload
def TemporaryFile(
mode: _BytesMode = "w+b",
buffering: int = -1,
mode: _BinaryMode,
buffering: Literal[0],
encoding: str | None = None,
newline: str | None = None,
suffix: AnyStr | None = None,
prefix: AnyStr | None = None,
dir: GenericPath[AnyStr] | None = None,
*,
errors: str | None = None,
) -> io.FileIO: ...
@overload
def TemporaryFile(
mode: _BinaryMode = "w+b",
buffering: Literal[-1, 1] = -1,
encoding: str | None = None,
newline: str | None = None,
suffix: AnyStr | None = None,
prefix: AnyStr | None = None,
dir: GenericPath[AnyStr] | None = None,
*,
errors: str | None = None,
) -> IO[bytes]: ...
) -> io.BufferedRandom: ...
@overload
def TemporaryFile(
mode: str = "w+b",
Expand All @@ -152,24 +166,34 @@ else:
else:
@overload
def TemporaryFile(
mode: _StrMode,
mode: _TextMode,
buffering: int = ...,
encoding: str | None = ...,
newline: str | None = ...,
suffix: AnyStr | None = ...,
prefix: AnyStr | None = ...,
dir: GenericPath[AnyStr] | None = ...,
) -> IO[str]: ...
) -> io.TextIOWrapper: ...
@overload
def TemporaryFile(
mode: _BytesMode = ...,
buffering: int = ...,
mode: _BinaryMode,
buffering: Literal[0],
encoding: str | None = ...,
newline: str | None = ...,
suffix: AnyStr | None = ...,
prefix: AnyStr | None = ...,
dir: GenericPath[AnyStr] | None = ...,
) -> io.FileIO: ...
@overload
def TemporaryFile(
mode: _BinaryMode = ...,
buffering: Literal[-1, 1] = ...,
encoding: str | None = ...,
newline: str | None = ...,
suffix: AnyStr | None = ...,
prefix: AnyStr | None = ...,
dir: GenericPath[AnyStr] | None = ...,
) -> IO[bytes]: ...
) -> io.BufferedRandom: ...
@overload
def TemporaryFile(
mode: str = ...,
Expand Down Expand Up @@ -246,7 +270,7 @@ class SpooledTemporaryFile(IO[AnyStr], _SpooledTemporaryFileBase):
def __init__(
self: SpooledTemporaryFile[bytes],
max_size: int = 0,
mode: _BytesMode = "w+b",
mode: _BinaryMode = "w+b",
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand All @@ -260,7 +284,7 @@ class SpooledTemporaryFile(IO[AnyStr], _SpooledTemporaryFileBase):
def __init__(
self: SpooledTemporaryFile[str],
max_size: int,
mode: _StrMode,
mode: _TextMode,
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand All @@ -275,7 +299,7 @@ class SpooledTemporaryFile(IO[AnyStr], _SpooledTemporaryFileBase):
self: SpooledTemporaryFile[str],
max_size: int = 0,
*,
mode: _StrMode,
mode: _TextMode,
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand Down Expand Up @@ -319,7 +343,7 @@ class SpooledTemporaryFile(IO[AnyStr], _SpooledTemporaryFileBase):
def __init__(
self: SpooledTemporaryFile[bytes],
max_size: int = 0,
mode: _BytesMode = "w+b",
mode: _BinaryMode = "w+b",
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand All @@ -331,7 +355,7 @@ class SpooledTemporaryFile(IO[AnyStr], _SpooledTemporaryFileBase):
def __init__(
self: SpooledTemporaryFile[str],
max_size: int,
mode: _StrMode,
mode: _TextMode,
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand All @@ -344,7 +368,7 @@ class SpooledTemporaryFile(IO[AnyStr], _SpooledTemporaryFileBase):
self: SpooledTemporaryFile[str],
max_size: int = 0,
*,
mode: _StrMode,
mode: _TextMode,
buffering: int = -1,
encoding: str | None = None,
newline: str | None = None,
Expand Down
0