Loosen constraints on ujson file functions #10081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like `json.dump`, `ujson.dump` takes any object that has a string-accepting `.write` method. Similarly, `ujson.load` works with any object with a `.read()` that returns either a string or a bytes
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Apr 25, 2023
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
tjstum
commented
Apr 25, 2023
| @@ -47,6 +47,6 @@ def dump( | |||
| ) -> None: ... | |||
| def decode(s: AnyStr, precise_float: bool = ...) -> Any: ... | |||
There was a problem hiding this comment.
@AlexWaygood should I also remove these (since they aren't being used as a TypeVar)?
There was a problem hiding this comment.
Yes, they look incorrect. I didn't want to ask you to change them in this PR since they are unrelated to the change you were making, but a followup PR fixing these would be welcome! :)
tjstum
added a commit
to tjstum/typeshed
that referenced
this pull request
Apr 26, 2023
Followup from python#10081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
json.dump,ujson.dumptakes any object that has a string-accepting.writemethod.Similarly,
ujson.loadworks with any object with a.read()that returns either a string or a bytes