8000 Switch to GitHub Actions, since Travis shuts down by sobolevn · Pull Request #310 · python/the-knights-who-say-ni · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Jul 8, 2022. It is now read-only.

Switch to GitHub Actions, since Travis shuts down #310

Merged
merged 11 commits into from
Feb 23, 2022
Merged

Switch to GitHub Actions, since Travis shuts down #310

merged 11 commits into from
Feb 23, 2022

Conversation

sobolevn
Copy link
Member

No description provided.

JelleZijlstra
JelleZijlstra approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the action won't actually run until this is merged. It's probably easiest to just merge it, then make another PR to confirm it works. Alternatively, we could test on a fork.

@sobolevn
Copy link
Member Author
sobolevn commented Feb 22, 2022 •
edited
Loading

Testing on a fork: https://github.com/sobolevn/the-knights-who-say-ni/actions/runs/1882897919
It is green ✅

Mariatta
Mariatta approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member
@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mariatta
Copy link
Member

Well I can't merge since travis CI are still set as required. I don't have admin access to change this. 😥

@sobolevn
Copy link
Member Author

CC @ewdurbin

hugovk
hugovk suggested changes Feb 23, 2022
View reviewed changes
hugovk
hugovk reviewed Feb 23, 2022
View reviewed changes
@sobolevn
Copy link
Member Author

Thank you! 👍

@sobolevn
Copy link
Member Author

Refs python-hyper/uritemplate#77

@sobolevn
Copy link
Member Author

Latest CI finally passes 🎉
https://github.com/sobolevn/the-knights-who-say-ni/actions/runs/1887353477

hugovk
hugovk approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@ewdurbin
Copy link
Member

Branch rule requiring Travis removed.

Mariatta and others added 2 commits February 23, 2022 09:16
@Mariatta @hugovk
Update .github/workflows/ci.yml
1ea85c2 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@Mariatta @hugovk
Update .github/workflows/ci.yml
923fbe3 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Mariatta
Mariatta approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member
@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mariatta Mariatta merged commit 50351df into python:master Feb 23, 2022
@ewdurbin ewdurbin mentioned this pull request Feb 23, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hugovk hugovk hugovk approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sobolevn @Mariatta @ewdurbin @JelleZijlstra @hugovk @the-knights-who-say-ni
0