8000 Use 'regen-configure' Makefile target by sethmlarson · Pull Request #79 · python/release-tools · GitHub
[go: up one dir, main page]
Skip to content

Use 'regen-configure' Makefile target #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

Use 'regen-configure' Makefile target #79

merged 1 commit into from
Dec 18, 2023

Conversation

sethmlarson
Copy link
Collaborator

Follow-up from python/cpython#112160
Closes #70

This uses make regen-configure instead of pulling in the Docker container. In the latest CPython branch we no longer use the autoconf container and in past branches the container is pinned to a hash which is preferable over a tag.

ezio-melotti
ezio-melotti approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member
@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See also:

@sethmlarson sethmlarson merged commit 12b269b into python:master Dec 18, 2023
@sethmlarson sethmlarson deleted the make-regen-configure branch December 18, 2023 15:23
@sethmlarson
Copy link
Collaborator Author

Nice, thanks @ezio-melotti for the review and link!

@Yhg1s
Copy link
Member
Yhg1s commented Jan 16, 2024

This does not seem like the correct change:

✅  Preparing pydoc topics
make: *** No rule to make target 'regen-configure'.  Stop.
💥  Running autoconf
Traceback (most recent call last):
  File "./run_release.py", line 1058, in <module>
    main()
  File "./run_release.py", line 1054, in main
    automata.run()
  File "./run_release.py", line 253, in run
    raise e from None
  File "./run_release.py", line 250, in run
    self.current_task(self.db)
  File "./run_release.py", line 188, in __call__
    return ge
9B10
tattr(self, "function")(db)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "./run_release.py", line 414, in run_autoconf
    subprocess.check_call(
  File "/usr/lib/python3.11/subprocess.py", line 413, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', 'regen-configure']' returned non-zero exit status 2.

The point at which configure is regenerated is before configure is run, so there is no Makefile and thus no 'regen-configure' make target.

@sethmlarson sethmlarson mentioned this pull request Jan 17, 2024
Closed
@sethmlarson sethmlarson restored the make-regen-configure branch January 18, 2024 20:52
@sethmlarson sethmlarson deleted the make-regen-configure branch January 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pin the cpython_autoconf container to a sha256 manifest
3 participants
@sethmlarson @Yhg1s @ezio-melotti
0