Add display label to Tiered Benefits #2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
approved these changes
Aug 11, 2022
The ordering in Meta was change by 0197bd5
b6fb3fa to
f2872e0
Compare
ewdurbin
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames both
TieredQuantityandTieredQuantityConfigurationtoTieredBenefitandTieredBenefitConfiguration. The renaming goal is to make it more generic since this PR also adds a newdisplay_labelattribute to both models. This label wil take precedence over the quantity when listing the benefit in the sponsorship application form and also when modifying the benefit's name (during contract generation, for example).