FFFF Add Py_SETREF and Py_CLEAR operations by vstinner · Pull Request #56 · python/pythoncapi-compat · GitHub
[go: up one dir, main page]
Skip to content

Add Py_SETREF and Py_CLEAR operations #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 2 commits into from
Nov 27, 2022
Merged

Add Py_SETREF and Py_CLEAR operations #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad7ddef
Add Py_SETREF and Py_CLEAR operations
vstinner Nov 14, 2022
902ee12
Py_CLEAR doesn't replace Py_DECREF()
vstinner Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Changelog
=========

* 2022-11-15: Add experimental operations to the upgrade_pythoncapi script:
``Py_INCREF_return``, ``Py_INCREF_assign``, ``Py_CLEAR`` and ``Py_SETREF``.
* 2022-11-09: Fix ``Py_SETREF()`` and ``Py_XSETREF()`` macros
for `gh-98724 <https://github.com/python/cpython/issues/98724>`_.
* 2022-11-04: Add ``PyFrame_GetVar()`` and ``PyFrame_GetVarString()``
Expand Down
28 changes: 28 additions & 0 deletions docs/upgrade.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,3 +141,31 @@ PyThreadState_GetFrame
----------------------

* Replace ``tstate->frame`` with ``_PyThreadState_GetFrameBorrow(tstate)``.

Experimental operations
-----------------------

The following operations are experimental (ex: can introduce compiler warnings)
and so not included in the ``all`` group, they have to be selected explicitly.
Example: ``-o all,Py_SETREF``.

Experimental operations:

* ``Py_INCREF_return``:

* Replace ``Py_INCREF(res); return res;`` with ``return Py_NewRef(res);``

* ``Py_INCREF_assign``:

* Replace ``x = y; Py_INCREF(x);`` with ``x = Py_NewRef(y);``
* Replace ``x = y; Py_INCREF(y);`` with ``x = Py_NewRef(y);``
* Replace ``Py_INCREF(y); x = y;`` with ``x = Py_NewRef(y);``

* ``Py_CLEAR``:

* Replace ``Py_XDECREF(var); var = NULL;`` with ``Py_CLEAR(var);``

* ``Py_SETREF``:

* Replace ``Py_DECREF(x); x = y;`` with ``Py_SETREF(x, y);``
* Replace ``Py_XDECREF(x); x = y;`` with ``Py_XSETREF(x, y);``
Loading
0