Point to cpython/Doc/requirements.txt instead of duplicating it every time #3301
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's also do some alpha-sorting and small cleanup. Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
cmaureir
approved these changes
Nov 22, 2024
cmaureir
pushed a commit
that referenced
this pull request
Nov 23, 2024
La acción comenzó a fallar (e.g. https://github.com/python/python-docs-es/actions/runs/11980786740/job/33405766523?pr=3304) después de mergear #3301. Esto porque la acción realiza un "sparse checkout" (para ahorrar tiempo) de ciertos archivos, y con #3301 este checkout hubiese tenido que haber incluido a todo el submódulo cpython, con lo cual se hubieran agregado varios seguidos más a la ejecución del GHA. Este PR separa nuestras propias dependencias en un nuevo archivo `requirements-own.txt` que es incluido por `requirements.txt`, pero que también puede ser referenciado de forma separada. El GHA en cuestión efectivamente ahora sólo instala `requirements-own.txt`, evitando así referenciar al submódulo de cpython. Por otro lado, tener nuestras propias dependencias en un archivo separado no es malo en términos de organización de la información. Nótese que este PR en sí va a fallar, ya que el archivo .yaml definiendo el GHA fallido se toma de la rama principla, no la del PR. Pero en rtobar#9 pueden ver que el fix funciona al abrir un PR contra una rama donde el fix ya está puesto. --------- Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's also do some alpha-sorting and small cleanup.