Fix sqlglot normalize benchmark #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mdboom |
Contributor
Author
|
So, the pull request seems ready :) |
In the current sqlglot normalized, conjunction string would be modified to its normalized form after the first iteration. And for the remaining iterations, normalization function was applied to the normalized form of the original conjunction string. Therefore, the performance of the first iteration would be different to the remaining iterations. This causes unsuitability in performance reports. To fix this issue, we created the V2 version, in which, a new conjunction string is created for every individual iteration.
mdboom
approved these changes
Feb 4, 2025
Contributor
There was a problem hiding this comment.
Thanks, this is really helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sqlglot to V2
In the current sqlglot normalized, conjunction string would be modified to its normalized form after the first iteration.
And for the remaining iterations, normalization function was applied to the normalized form of the original conjunction string.
Therefore, the performance of the first iteration would be different to the remaining iterations.
This causes unsuitability in performance reports.
To fix this issue, we created the V2 version, in which, a new conjunction string is created for every individual iteration.