8000 Add `list.sort` benchmarks by sobolevn · Pull Request #328 · python/pyperformance · GitHub
[go: up one dir, main page]
Skip to content

Add list.sort benchmarks #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add list.sort benchmarks #328

wants to merge 3 commits into from

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Feb 7, 2024

As requested in python/cpython#114687 by @corona10 I ported this script into pyperformance.

Changes:

  1. Now we have new sorting group
  2. All previous cases were translated into a separate benchmark (they are different only by the input data)

@corona10
Copy link
Member
corona10 commented Feb 7, 2024

@gvanrossum Do you think that it is okay to relocate list.sort benchmark in here?

@sobolevn
Copy link
Member Author
sobolevn commented Feb 7, 2024

This still happens:

[40/88] list_sort_ascending_exchanged...
# /home/runner/work/pyperformance/pyperformance/venv/cpython3.11-3c206e65878c-compat-3c0fde653f89/bin/python -u /home/runner/work/pyperformance/pyperformance/pyperformance/data-files/benchmarks/bm_list_sort/run_benchmark.py list_sort_ascending_exchanged --debug-single-value --output /tmp/tmphqhu0yau --inherit-environ PYPERFORMANCE_RUNID
.
WARNING: the benchmark result may be unstable
* the shortest raw value is only 285 us

Try to rerun the benchmark with more runs, values and/or loops.
Run 'python -m pyperf system tune' command to reduce the system jitter.
Use pyperf stats, pyperf dump and pyperf hist to analyze results.
Use --quiet option to hide these warnings.

@sobolevn
Copy link
Member Author
sobolevn commented Feb 7, 2024

WARNING: the benchmark result may be unstable is gone!

@gvanrossum
Copy link
Member

@gvanrossum Do you think that it is okay to relocate list.sort benchmark in here?

My response is the same as for the decimal benchmark: moving this benchmark here is not going to help us speed up the Python interpreter, it will just make it harder for us to show any improvements. Maybe put this benchmark in Tools/scripts?

@sobolevn sobolevn closed this Feb 9, 2024
@sobolevn
Copy link
Member Author
sobolevn commented Feb 9, 2024

Maybe put this benchmark in Tools/scripts?

Sounds good to me! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @corona10 @gvanrossum
0