8000 Add jobs field in compile section to specify make -j param by aisk · Pull Request #236 · python/pyperformance · GitHub
[go: up one dir, main page]
Skip to content

Add jobs field in compile section to specify make -j param #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2022
Merged

Add jobs field in compile section to specify make -j param #236

merged 3 commits into from
Sep 27, 2022

Conversation

aisk
Copy link
Contributor
@aisk aisk commented Sep 9, 2022

For reduce compilation time cost in multi core machines.

ericsnowcurrently
ericsnowcurrently requested changes Sep 13, 2022
View reviewed changes
Copy link
Member
@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of adding this and the change mostly looks good. I have but one recommendation first.

ericsnowcurrently
ericsnowcurrently requested changes Sep 16, 2022
View reviewed changes
Copy link
Member
@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change. There's just one more thing to fix: the default value.

aisk and others added 2 commits September 27, 2022 15:04
@aisk @ericsnowcurrently
Update pyperformance/compile.py
aad9f6c 
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@aisk @ericsnowcurrently
Update pyperformance/compile.py
8713823 
Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently
ericsnowcurrently approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member
@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently merged commit c457e5b into python:main Sep 27, 2022
@ericsnowcurrently
Copy link
Member

Thanks for the patch, @aisk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aisk @ericsnowcurrently
0