8000 PEP 791: Mark as Final by skirpichev · Pull Request #4671 · python/peps · GitHub
[go: up one dir, main page]
Skip to content

PEP 791: Mark as Final #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 4, 2025
Merged

PEP 791: Mark as Final #4671

merged 11 commits into from
Nov 4, 2025

Conversation

@skirpichev
Copy link
Contributor
@skirpichev skirpichev commented Oct 23, 2025 •
edited by hugovk
Loading
  • SC/PEP Delegate has formally accepted/rejected the PEP and posted to the Discussions-To thread
  • Pull request title in appropriate format (PEP 123: Mark as Accepted)
  • Status changed to Accepted/Rejected
  • Resolution field points directly to SC/PEP Delegate official acceptance/rejected post, including the date (e.g. `01-Jan-2000 <https://discuss.python.or 8000 g/t/12345/100>`__)
  • Acceptance/rejection notice added, if the SC/PEP delegate had major conditions or comments
  • Discussions-To, Post-History and Python-Version up to date
  • Final implementation has been merged (including tests and docs)
  • PEP matches the final implementation
  • Any substantial changes since the accepted version approved by the SC/PEP delegate
  • Pull request title in appropriate format (PEP 123: Mark as Final)
  • Status changed to Final (and Python-Version is correct)
  • Canonical docs/spec linked with a canonical-doc directive
    (or canonical-pypa-spec for packaging PEPs,
    or canonical-typing-spec for typing PEPs)

📚 Documentation preview 📚: https://pep-previews--4671.org.readthedocs.build/

https://pep-previews--4671.org.readthedocs.build/pep-0791/

@skirpichev skirpichev requested a review from vstinner as a code owner October 23, 2025 22:45
@skirpichev
Copy link
Contributor Author
skirpichev commented Oct 23, 2025

CC @NeilGirdhar, @tim-one, @serhiy-storchaka

I hope you are ok with changing the Author field. Let me know if you aren't or would like to change final text somehow.

tim-one
tim-one approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member
@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for enduring this process 😄.

@hugovk
Copy link
Member
hugovk commented Oct 25, 2025

@warsaw Before merge, please could you clarify the decision on intmath?

Re: https://discuss.python.org/t/pep-791-imath-module-for-integer-specific-mathematics-functions/92548/164

@skirpichev
Copy link
Contributor Author
skirpichev commented Oct 25, 2025

BTW, please don't merge without acknowledgment/approval from Serhiy.

@hugovk hugovk marked this pull request as draft October 25, 2025 09:38
@warsaw
Copy link
Member
warsaw commented Oct 25, 2025

@warsaw Before merge, please could you clarify the decision on intmath?

Re: https://discuss.python.org/t/pep-791-imath-module-for-integer-specific-mathematics-functions/92548/164

I suggest making it clearer in that text that the intmath package being described is a separate backport package on PyPI.

@skirpichev skirpichev marked this pull request as ready for review October 25, 2025 22:45
@vstinner
Copy link
Member
vstinner commented Oct 28, 2025

ping @NeilGirdhar and @serhiy-storchaka

@NeilGirdhar
Copy link
Contributor
NeilGirdhar commented Oct 28, 2025

@vstinner Okay I'll review it in the next hour :)

@NeilGirdhar
Copy link
Contributor
NeilGirdhar commented Oct 28, 2025 •
edited
Loading

LGTM!

(Very minor, but you could change "for an indefinite time" to "indefinitely".)

@skirpichev
Copy link
Contributor Author
skirpichev commented Oct 31, 2025

Implementation was merged. @serhiy-storchaka, are you OK with changes in authors?

vstinner
vstinner reviewed Nov 1, 2025
View reviewed changes
@skirpichev skirpichev changed the title PEP 791: mark as accepted, final edits PEP 791: mark as final, last edits Nov 2, 2025
@skirpichev skirpichev changed the title PEP 791: mark as final, last edits PEP 791: Mark as Final Nov 2, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member
@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initiated the first too attempts, but my participation in this PEP was limited to historical references and minor comments. So its up to you.

@vstinner vstinner merged commit 107eeb5 into python:main Nov 4, 2025
5 checks passed
@vstinner
Copy link
Member
vstinner commented Nov 4, 2025

All new co-authors approved the PEP. I merge the PR.

@skirpichev skirpichev deleted the pep791-final branch November 4, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@hugovk hugovk hugovk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@tim-one tim-one tim-one approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@skirpichev @hugovk @warsaw @vstinner @NeilGirdhar @serhiy-storchaka @tim-one
0