-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
All PEPs: Move to peps/
folder
#3418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We 8000 ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First up, some extra pre-commit cleanup.
I reviewed the pre-commit guidance---it seems that our usages of A |
- Group ignores by purpose - Remove 'package' - Remove 'pep-????.html' - Allow topic to cover top level or in peps/
Out of a slight fear of this going the same way as #2672, please may I ask if anyone has any burning passions against the general proposal to move the PEPs into a sub-folder? (We can tweak implementation details later, of course.) If all is well, I'd like to set a timeline for merging this -- perhaps Tuesday or Wednesday, if that's not too early? A |
No burning passions, no. Just a broad "is this worth the effort", but I'm not going to stand in anyone's way. |
# Conflicts: # .pre-commit-config.yaml # pep_sphinx_extensions/tests/conftest.py
I'll merge this today, sorry in advance for the review-request spam. A |
I'll keep an eye on https://peps.python.org just in case. |
All seems well! A |
Current PEPs links are dead since python/peps#3418
@Jose1654 'approving' merged pull requests spams a large number of people and is otherwise useless. Please do not repeat. |
I already reported the user to GitHub for spamming. Are we able to disallow reviews from non-members? This keeps happening, every once in a while. |
We can disallow reviews that approve/request changes for those without explicit read access, but not cannot disallow comment reviews. Do we get useful approve/request-change reviews from real non-members? We often have external co-authors. They can add a comment instead, but is that ok? |
I would oppose changing this configuration because of the occasional random user doing something annoying. Just ignore them. Users outside the Python org can and do leave useful reviews, especially on this repo. |
Yeah, that's fair. It'd be nice to be able to disallow drive-bys from people who have had no other interaction AND who don't leave any comments in the review, but that's a bit too sophisticated to ask for. |
Would resolve #10.
cc: @python/pep-editors for views.
I've structured as distinct commits -- the first does the actual move, the following thirteen tackle follow-ups and previous assumptions over file locations.
A
📚 Documentation preview 📚: https://pep-previews--3418.org.readthedocs.build/