8000 All PEPs: Move to ``peps/`` folder by AA-Turner · Pull Request #3418 · python/peps · GitHub
[go: up one dir, main page]

Skip to content

All PEPs: Move to peps/ folder #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We 8000 ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Sep 9, 2023
Merged

Conversation

AA-Turner
Copy link
Member
@AA-Turner AA-Turner commented Sep 3, 2023

Would resolve #10.

cc: @python/pep-editors for views.

I've structured as distinct commits -- the first does the actual move, the following thirteen tackle follow-ups and previous assumptions over file locations.

A


📚 Documentation preview 📚: https://pep-previews--3418.org.readthedocs.build/

Copy link
Member
@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First up, some extra pre-commit cleanup.

@AA-Turner
Copy link
Member Author

I reviewed the pre-commit guidance---it seems that our usages of types: were mostly redundant due to filtering files to match PEPs, so I've just removed them.

A

- Group ignores by purpose
- Remove 'package'
- Remove 'pep-????.html'
- Allow topic to cover top level or in peps/
@AA-Turner
Copy link
Member Author

Out of a slight fear of this going the same way as #2672, please may I ask if anyone has any burning passions against the general proposal to move the PEPs into a sub-folder? (We can tweak implementation details later, of course.)

If all is well, I'd like to set a timeline for merging this -- perhaps Tuesday or Wednesday, if that's not too early?

A

@Rosuav
Copy link
Contributor
Rosuav commented Sep 4, 2023

No burning passions, no. Just a broad "is this worth the effort", but I'm not going to stand in anyone's way.

@AA-Turner
Copy link
Member Author

I'll merge this today, sorry in advance for the review-request spam.

A

@AA-Turner
Copy link
Member Author

I'll keep an eye on https://peps.python.org just in case.

@AA-Turner
Copy link
Member Author

All seems well!

A

@AA-Turner AA-Turner deleted the peps-in-peps branch September 9, 2023 17:53
joshuabambrick added a commit to joshuabambrick/steering-council that referenced this pull request Dec 2, 2023
Current PEPs links are dead since python/peps#3418
@terryjreedy
Copy link
Member

@Jose1654 'approving' merged pull requests spams a large number of people and is otherwise useless. Please do not repeat.

@Rosuav
Copy link
Contributor
Rosuav commented May 4, 2025

@Jose1654 'approving' merged pull requests spams a large number of people and is otherwise useless. Please do not repeat.

I already reported the user to GitHub for spamming. Are we able to disallow reviews from non-members? This keeps happening, every once in a while.

@hugovk
Copy link
Member
hugovk commented May 4, 2025

We can disallow reviews that approve/request changes for those without explicit read access, but not cannot disallow comment reviews.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-pull-request-reviews-in-your-repository

Do we get useful approve/request-change reviews from real non-members?

We often have external co-authors. They can add a comment instead, but is that ok?

@JelleZijlstra
Copy link
Member

I would oppose changing this configuration because of the occasional random user doing something annoying. Just ignore them.

Users outside the Python org can and do leave useful reviews, especially on this repo.

@Rosuav
Copy link
Contributor
Rosuav commented May 4, 2025

Yeah, that's fair. It'd be nice to be able to disallow drive-bys from people who have had no other interaction AND who don't leave any comments in the review, but that's a bit too sophisticated to ask for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move peps into subdirectory
8 participants
0