8000 Implement support for sticky banners and utilize them by pradyunsg · Pull Request #2992 · python/peps · GitHub
[go: up one dir, main page]
Skip to content

Implement support for sticky banners and utilize them #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 20, 2023
Merged

Implement support for sticky banners and utilize them #2992

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9f56b6a
Implement support for sticky banners
pradyunsg Jan 29, 2023
a287533
Remove repeated specification of base banner class
pradyunsg Jan 29, 2023
9a35740
Replace bespoke and unused banner classes with `sticky-banner`
pradyunsg Jan 29, 2023
7bdba97
Use attention admonition for PyPA PEP banners
pradyunsg Jan 29, 2023
418eec5
Make attention admonition more attention grabbing
pradyunsg Jan 29, 2023
6041230
fixup! Implement support for sticky banners
pradyunsg Mar 11, 2023
3ee8d18
fixup! Implement support for sticky banners
pradyunsg Mar 11, 2023
4546e7a
Revert "Replace bespoke and unused banner classes with `sticky-banner`"
pradyunsg Mar 11, 2023
f2e0519
Add back the sticky-banner CSS class
pradyunsg Mar 11, 2023
ae0c2bb
Merge branch 'main' into sticky-banners
pradyunsg Mar 11, 2023
3c4021a
Merge branch 'main' into sticky-banners
pradyunsg Mar 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add back the sticky-banner CSS class
  • Loading branch information
@pradyunsg
pradyunsg committed Mar 11, 2023
commit f2e051973bf5d372f8a5b9ede69c529a8562fc3f
4 changes: 2 additions & 2 deletions pep_sphinx_extensions/pep_processor/parsing/pep_banner_directive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class CanonicalDocBanner(PEPBanner):
"See :pep:`1` for how to propose changes."
)

css_classes = ["canonical-doc"]
css_classes = ["canonical-doc", "sticky-banner"]



Expand All @@ -99,4 +99,4 @@ class CanonicalPyPASpecBanner(PEPBanner):
)
admonition_class = nodes.attention

css_classes = ["canonical-pypa-spec"]
css_classes = ["canonical-pypa-spec", "sticky-banner"]
0