8000 Infra: Use dark grey instead of dark green for dark theme background by hugovk · Pull Request #2977 · python/peps · GitHub
[go: up one dir, main page]
Skip to content

Infra: Use dark grey instead of dark green for dark theme background #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of servi 8000 ce and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2023
Merged

Infra: Use dark grey instead of dark green for dark theme background #2977

merged 2 commits into from
Jan 24, 2023

Conversation

hugovk
Copy link
Member
@hugovk hugovk commented Jan 22, 2023

Without wanting to bikeshed too much!

The dark theme's current background colour has a bit of a greenish tint: #001111 (labelled "Dark Green" on some sites) which looks a bit off.

The background shouldn't be pure black, the contrast is too high. Here's what a few other sites use:

Previews:

#001111
#121212
#202020
#202124
#2d2d2d
image image image image image

Material Design's #121212 is often suggested (1, 2, 3, 4) so I've gone for that.

No contrast errors at https://wave.webaim.org/report#/https://hugovk-peps.readthedocs.io/en/dark-bgcolor/ or https://wave.webaim.org/report#/https://hugovk-peps.readthedocs.io/en/dark-bgcolor/pep-0008.

Demo

https://pep-previews--2977.org.readthedocs.build/

@hugovk hugovk added the infra Core infrastructure for building and rendering PEPs label Jan 22, 2023
@hugovk hugovk requested a review from AA-Turner as a code owner January 22, 2023 18:50
CAM-Gerlach
CAM-Gerlach reviewed Jan 22, 2023
View reviewed changes
Copy link
Member
@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tweak, otherwise SGTM

@hugovk @CAM-Gerlach
Use #1111111 for dark theme bgcolor
f98c9f6 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
CAM-Gerlach
CAM-Gerlach approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member
@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk !

@hugovk hugovk merged commit 15caa8f into python:main Jan 24, 2023
@hugovk hugovk deleted the dark-bgcolor branch January 24, 2023 05:53
JelleZijlstra pushed a commit to JelleZijlstra/peps that referenced this pull request Jan 24, 2023
@hugovk @CAM-Gerlach @JelleZijlstra
Infra: Use dark grey instead of dark green for dark theme background (p…
c89fa77 
…ython#2977)

* Use #121212 for dark theme bgcolor

* Use #1111111 for dark theme bgcolor

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@hugovk hugovk mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees
No one assigned
Labels
infra Core infrastructure for building and rendering PEPs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @CAM-Gerlach
0