PEP 678: simplify specification to use a list #2456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool.
We can do that in a separate PR. |
iritkatriel
reviewed
Mar 22, 2022
iritkatriel
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following further discussion (a running theme), the pendulum has swung back towards a simpler and less-tightly-specified interface. Loosely,
__notes__will be a list, created on the first call toadd_note(), and if it's been messed up by the user we'll raise errors (inadd_note()) or print a placeholder message (at display time) as appropriate. This mirrors the existing handling of maybe-not-stringifiable exception instances, and permits all kinds of advanced shennanigans from users (or alternative implementations) who wish to push the system.In the last few minutes I've also seen new messages about prior art in Tensorflow (a
utils.reraise()helper) and circa-2013 discussions on BPO and python-dev, but it's late enough here that I'll push further updates in tomorrow.